-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Groups JavaFX Rework #1438
Conversation
I vote for leaving it for now and focusing on the current system instead. We try to wait for the feedback on using JavaFX from the stupro to decide how much effort a change would be. |
In my opinion there is no problem in partly switching to the new JavaFX technology. Either you embedd JavaFX elements in swing using |
groupTree.setRoot(root); | ||
} | ||
|
||
public static class CheckBoxTreeTableRowSkin<S> extends TreeTableRowSkin<S> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New class should be in a new file
How much work is it to get this merged into javafx? Does the current work on grouping influence this PR? |
Around 1-2 weeks for a working minimal version (display of the groups tree and adding/editing of groups) but a few more until all current features are included. |
I just close this PR as we currently focus on other issues. We will reopen as soon as we continue working on it. |
Any news on this? I would still be quite interested in the JavaFX rework, especially since this was supposed to provide the functionality proposed in #1904 |
We will now continue with our efforts to move on to JavaFX (there are already some dialogs implemented). However, I don't know if and when @tobiasdiez will be able to continue on this. |
Thanks - hmm, I see. Do you think it would be necessary to reopen this issue (just to raise awareness)? Or is it all right the way it's now? |
I played around a bit with JavaFX and tried to redesign the group pane.

The result:
Question: so far it it is just the ui with dummy test data and without any interaction. If I now start to port everything to JavaFX then the JavaFX branch will diverge immensely from the master. Should I stop here and leave it as a prototype for now or should I finish it?