Update Preview Panel on Generate BibtexKey #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08c8747 to
daf4437
Compare
Current coverage is 27.56%@@ master #1355 diff @@
==========================================
Files 695 695
Lines 46296 46294 -2
Methods 0 0
Messages 0 0
Branches 7650 7650
==========================================
Hits 12759 12759
+ Misses 32437 32435 -2
Partials 1100 1100
|
|
ATM the crossRef Test is failing, I get a timeout. Otherwise this build is fine. |
| @@ -537,7 +538,7 @@ private void generateKeys() { | |||
| for (BibEntry entry : entries) { | |||
| database.removeEntry(entry); | |||
| } | |||
| entries.getReadWriteLock().writeLock().lock(); | |||
| entries.getReadWriteLock().writeLock().unlock(); | |||
There was a problem hiding this comment.
Can you create a try-finally with unlocking the lock in the finally part? This should be done in the other part of the code as well.
|
LGTM Please address my comment, then this can be rebased and merged. |
Fix for JabRef#1353 Use locking with lock try unlock Some formatting Encapsulate frame in getter
daf4437 to
c09a123
Compare
|
Gradle test execution fails on travis (Code 137 -> Travis issued a SIGKILL) . Seems to be a memory/resource related problem: |
|
Can be merged. |
tschechlovdev
pushed a commit
to tschechlovdev/jabref
that referenced
this pull request
May 21, 2016
Fix for JabRef#1353 Use locking with lock try unlock Some formatting Encapsulate frame in getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1353
Fixed some missing unlocks
Some formatting