Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preliminary fix for #1340 #1344

Merged
merged 1 commit into from
May 10, 2016
Merged

preliminary fix for #1340 #1344

merged 1 commit into from
May 10, 2016

Conversation

chochreiner
Copy link
Collaborator

Added a textual description for the functionality "Mark Specific Color" since some Look and Feels (including the OSX one) do not consider the Background and Foreground color (at least for) JMenuItem

the current fix at least provides some kind of indicator of the level instead of a blank field as before

@chochreiner chochreiner mentioned this pull request May 3, 2016
@chochreiner chochreiner added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 3, 2016
@simonharrer
Copy link
Contributor

Would it make sense to use this for the other menu as well, which can be used from within the right-click menu? Or is this not an issue there?

@chochreiner
Copy link
Collaborator Author

the right-click menu works as intended - nevertheless this PR also adds the Level 0 - Level 5 notion there

@simonharrer
Copy link
Contributor

LGTM

@stefan-kolb
Copy link
Member

Can you please quickly rebase this, then I'll merge this in.

@codecov-io
Copy link

codecov-io commented May 10, 2016

Current coverage is 27.56%

Merging #1344 into master will decrease coverage by -0.87%

@@             master      #1344   diff @@
==========================================
  Files           699        695     -4   
  Lines         46227      46294    +67   
  Methods           0          0          
  Messages          0          0          
  Branches       7633       7650    +17   
==========================================
- Hits          13145      12759   -386   
- Misses        31954      32435   +481   
+ Partials       1128       1100    -28   
  1. 5 files (not in diff) in .../net/sf/jabref/event were deleted. more
  2. 2 files (not in diff) in ...va/net/sf/jabref/sql were modified. more
    • Misses +1
  3. 3 files (not in diff) in ...jabref/specialfields were modified. more
    • Misses +1
  4. 2 files (not in diff) in ...f/jabref/model/entry were modified. more
    • Misses +9
    • Partials +1
    • Hits +8
  5. 2 files (not in diff) in ...abref/model/database were modified. more
    • Misses +3
    • Partials +1
    • Hits -1
  6. 2 files (not in diff) in ...sf/jabref/logic/util were modified. more
    • Misses +16
    • Partials -4
    • Hits -12
  7. 2 files (not in diff) in ...f/jabref/logic/msbib were modified. more
    • Misses +345
    • Partials -14
    • Hits -302
  8. 4 files (not in diff) in ...jabref/logic/cleanup were modified. more
    • Misses -1
    • Hits -4
  9. 5 files (not in diff) in .../net/sf/jabref/logic were modified. more
    • Misses +24
    • Hits -24
  10. 3 files (not in diff) in ...t/sf/jabref/importer were modified. more
    • Misses +5
    • Hits +1

Powered by Codecov. Last updated by dd96a7b...264e61f

@chochreiner
Copy link
Collaborator Author

done

@stefan-kolb
Copy link
Member

Merci 😄

@stefan-kolb stefan-kolb merged commit 8de514a into JabRef:master May 10, 2016
@chochreiner chochreiner deleted the OSXfix branch May 13, 2016 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants