-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preliminary fix for #1340 #1344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Would it make sense to use this for the other menu as well, which can be used from within the right-click menu? Or is this not an issue there? |
the right-click menu works as intended - nevertheless this PR also adds the Level 0 - Level 5 notion there |
LGTM |
Can you please quickly rebase this, then I'll merge this in. |
Current coverage is 27.56%@@ master #1344 diff @@
==========================================
Files 699 695 -4
Lines 46227 46294 +67
Methods 0 0
Messages 0 0
Branches 7633 7650 +17
==========================================
- Hits 13145 12759 -386
- Misses 31954 32435 +481
+ Partials 1128 1100 -28
|
done |
Merci 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a textual description for the functionality "Mark Specific Color" since some Look and Feels (including the OSX one) do not consider the Background and Foreground color (at least for) JMenuItem
the current fix at least provides some kind of indicator of the level instead of a blank field as before