Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force-push-detection #12513

Merged
merged 13 commits into from
Feb 16, 2025
Merged

Add force-push-detection #12513

merged 13 commits into from
Feb 16, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 16, 2025

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/795

Also adds better "line breaks" in Markdown - (Based on the information at https://de.wikipedia.org/wiki/YAML).

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor force-pushed the add-force-push-comment-action branch from 8aa88f2 to bb3b349 Compare February 16, 2025 19:29
@koppor koppor force-pushed the add-force-push-comment-action branch from 328cbba to 6ed0e9a Compare February 16, 2025 19:44
@koppor koppor force-pushed the add-force-push-comment-action branch from 677c950 to b61c762 Compare February 16, 2025 19:50
@koppor
Copy link
Member Author

koppor commented Feb 16, 2025

Only comments if all tests ran, Thus, a contributor might add a new commit (without force pushing), which would prevent a comment. But I think, this is better than nothing.

Copy link
Contributor

github-actions bot commented Feb 16, 2025

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@subhramit subhramit added this pull request to the merge queue Feb 16, 2025
Merged via the queue into main with commit 9dd8295 Feb 16, 2025
28 checks passed
@subhramit subhramit deleted the add-force-push-comment-action branch February 16, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants