Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #12274 Import at "Find Unlinked Files" should not re-add an identical entry #12506

Merged
merged 14 commits into from
Feb 18, 2025

Conversation

rocket125
Copy link
Contributor

@rocket125 rocket125 commented Feb 16, 2025

Closes #12274

Summary

This fix prevents "Search for unlinked local files" from re-adding already imported files with a second click on "Import". All import files will be unchecked. This provides visual indication to the user that their import is finish.

Changes Made

  • startImport in UnlinkedFilesDialog unchecks all files after importing

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, our issue description was not precise.

We added a test scenrio (at #12507) and a refined issue desription at #12274 (comment)

Please rewrite your code accordingly.

CHANGELOG.md Outdated Show resolved Hide resolved
@koppor koppor marked this pull request as draft February 16, 2025 14:55
@rocket125
Copy link
Contributor Author

I read the updated issue description

Disable combobox for imported files. --> This will indicate for the users that the file was imported

How would I proceed in disabling the comboboxes? I can only uncheck them.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

In case of issues with the import order, double check that you activated Auto Import.
You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

@koppor
Copy link
Member

koppor commented Feb 16, 2025

I read the updated issue description

Disable combobox for imported files. --> This will indicate for the users that the file was imported

How would I proceed in disabling the comboboxes? I can only uncheck them.

Uncheck is OK.

Disabling is blocked by controlsfx/controlsfx#825.

@rocket125 rocket125 marked this pull request as ready for review February 16, 2025 23:11
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 18, 2025
@koppor koppor added this pull request to the merge queue Feb 18, 2025
Merged via the queue into JabRef:main with commit 1e858b8 Feb 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import at "Find Unlinked Files" should not re-add an identical entry
3 participants