-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #12274 Import at "Find Unlinked Files" should not re-add an identical entry #12506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun
, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, our issue description was not precise.
We added a test scenrio (at #12507) and a refined issue desription at #12274 (comment)
Please rewrite your code accordingly.
- Remove test case from BibDatabaseTest.java
- Remove usage of containsEntryWithLinkedFile in UnlinkedFilesDialogView.java
I read the updated issue description
How would I proceed in disabling the comboboxes? I can only uncheck them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import.
You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
Uncheck is OK. Disabling is blocked by controlsfx/controlsfx#825. |
src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogView.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Closes #12274
Summary
This fix prevents "Search for unlinked local files" from re-adding already imported files with a second click on "Import". All import files will be unchecked. This provides visual indication to the user that their import is finish.
Changes Made
startImport
in UnlinkedFilesDialog unchecks all files after importingMandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)