Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some fetcher tests #12498

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Fix some fetcher tests #12498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9486518
Fix some fetcher tests
subhramit Feb 14, 2025
981693a
Merge branch 'main' into fetcher-tests
subhramit Feb 14, 2025
1a2427c
revert
Siedlerchr Feb 16, 2025
ebd17d1
Revert changes in in`BiodiversityLibraryTest`
subhramit Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/jabref/logic/importer/fetcher/BiodiversityLibrary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class BiodiversityLibrary implements SearchBasedParserFetcher, Customizab

private static final String BASE_URL = "https://www.biodiversitylibrary.org/api3";
private static final String RESPONSE_FORMAT = "json";
private static final String TEST_URL_WITHOUT_API_KEY = "https://www.biodiversitylibrary.org/api3?apikey=";
private static final String TEST_URL_WIH_OPTIONAL_KEY = "https://www.biodiversitylibrary.org/api3?apikey=";

private final ImporterPreferences importerPreferences;

Expand All @@ -55,7 +55,7 @@ public String getName() {

@Override
public String getTestUrl() {
return TEST_URL_WITHOUT_API_KEY;
return TEST_URL_WIH_OPTIONAL_KEY;
}

public URL getBaseURL() throws URISyntaxException, MalformedURLException {
Expand Down
7 changes: 3 additions & 4 deletions src/test/java/org/jabref/logic/importer/fetcher/DOABFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static Stream<Arguments> performSearch() {
.withField(StandardField.URL, "http://library.oapen.org/handle/20.500.12657/25535")
.withField(StandardField.URI, "https://directory.doabooks.org/handle/20.500.12854/34739")
.withField(StandardField.LANGUAGE, "English")
.withField(StandardField.KEYWORDS, "poetry, love, warfare")
.withField(StandardField.KEYWORDS, "poetry, love, warfare, thema EDItEUR::D Biography, Literature and Literary studies::DC Poetry::DCF Poetry by individual poets")
.withField(StandardField.PUBLISHER, "punctum books"),
"i open fire"
),
Expand All @@ -55,8 +55,7 @@ public static Stream<Arguments> performSearch() {
.withField(StandardField.URL, "http://library.oapen.org/handle/20.500.12657/25287")
.withField(StandardField.URI, "https://directory.doabooks.org/handle/20.500.12854/26303")
.withField(StandardField.LANGUAGE, "English")
.withField(StandardField.KEYWORDS, "Open Access, Monographs, OAPEN Library, " +
"Directory of Open Access Books")
.withField(StandardField.KEYWORDS, "Open Access, Monographs, OAPEN Library, Directory of Open Access Books, thema EDItEUR::G Reference, Information and Interdisciplinary subjects::GL Library and information sciences / Museology, thema EDItEUR::G Reference, Information and Interdisciplinary subjects::GP Research and information: general")
.withField(StandardField.PUBLISHER, "Amsterdam University Press"),
"the deliverance of open access books"
),
Expand All @@ -70,7 +69,7 @@ public static Stream<Arguments> performSearch() {
.withField(StandardField.URL, "https://library.oapen.org/handle/20.500.12657/48312")
.withField(StandardField.URI, "https://directory.doabooks.org/handle/20.500.12854/68086")
.withField(StandardField.LANGUAGE, "English")
.withField(StandardField.KEYWORDS, "Religion")
.withField(StandardField.KEYWORDS, "Religion, thema EDItEUR::Q Philosophy and Religion::QR Religion and beliefs::QRM Christianity::QRMF Christianity: sacred texts and revered writings::QRMF1 Bibles::QRMF13 New Testaments")
.withField(StandardField.PUBLISHER, "Brill"),
"Four Kingdom Motifs before and beyond the Book of Daniel"
),
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/jabref/logic/importer/fetcher/DoiFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ class DoiFetcherTest {
.withField(StandardField.PUBLISHER, "IEEE")
.withField(StandardField.TITLE, "BPEL4Chor: Extending BPEL for Modeling Choreographies")
.withField(StandardField.YEAR, "2007")
.withField(StandardField.PAGES, "296--303")
.withField(StandardField.DOI, "10.1109/icws.2007.59");
private final BibEntry bibEntryIannarelli2019 = new BibEntry(StandardEntryType.Article)
.withField(StandardField.AUTHOR,
Expand All @@ -54,7 +55,7 @@ class DoiFetcherTest {
.withField(StandardField.YEAR, "2019")
.withField(StandardField.DOI, "10.3303/CET1977146")
.withField(StandardField.JOURNAL, "Chemical Engineering Transactions")
.withField(StandardField.PAGES, "871-876")
.withField(StandardField.PAGES, "871–876")
.withField(StandardField.VOLUME, "77");
private final BibEntry bibEntryStenzel2020 = new BibEntry(StandardEntryType.Article)
.withCitationKey("Stenzel_2020")
Expand Down
19 changes: 8 additions & 11 deletions src/test/java/org/jabref/logic/importer/fetcher/IacrEprintFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,9 @@ void setUp() {
.withField(StandardField.ABSTRACT, "dummy")
.withField(StandardField.AUTHOR, "Ittai Abraham and Dahlia Malkhi and Kartik Nayak and Ling Ren and Alexander Spiegelman")
.withField(StandardField.DATE, "2017-11-24")
.withField(StandardField.HOWPUBLISHED, "Cryptology ePrint Archive, Paper 2017/1118")
.withField(StandardField.NOTE, "\\url{https://eprint.iacr.org/2017/1118}")
.withField(StandardField.HOWPUBLISHED, "Cryptology {ePrint} Archive, Paper 2017/1118")
.withField(StandardField.TITLE, "Solida: A Blockchain Protocol Based on Reconfigurable Byzantine Consensus")
.withField(StandardField.URL, "https://eprint.iacr.org/2017/1118/20171124:064527")
.withField(StandardField.URL, "https://eprint.iacr.org/archive/versions/2017/1118/20171124:064527")
.withField(StandardField.VERSION, "20171124:064527")
.withField(StandardField.YEAR, "2017");

Expand All @@ -75,10 +74,9 @@ void setUp() {
.withField(StandardField.AUTHOR, "Christof Beierle and Thorsten Kranz and Gregor Leander")
.withField(StandardField.DATE, "2017-02-17")
.withField(StandardField.DOI, "10.1007/978-3-662-53018-4_23")
.withField(StandardField.HOWPUBLISHED, "Cryptology ePrint Archive, Paper 2016/119")
.withField(StandardField.NOTE, "\\url{https://eprint.iacr.org/2016/119}")
.withField(StandardField.TITLE, "Lightweight Multiplication in GF(2^n) with Applications to MDS Matrices")
.withField(StandardField.URL, "https://eprint.iacr.org/2016/119/20170217:150415")
.withField(StandardField.HOWPUBLISHED, "Cryptology {ePrint} Archive, Paper 2016/119")
.withField(StandardField.TITLE, "Lightweight Multiplication in {GF}(2^n) with Applications to {MDS} Matrices")
.withField(StandardField.URL, "https://eprint.iacr.org/archive/versions/2016/119/20170217:150415")
.withField(StandardField.VERSION, "20170217:150415")
.withField(StandardField.YEAR, "2016");

Expand All @@ -87,10 +85,9 @@ void setUp() {
.withField(StandardField.ABSTRACT, "dummy")
.withField(StandardField.AUTHOR, "Sergi Delgado-Segura and Cristina Pérez-Solà and Guillermo Navarro-Arribas and Jordi Herrera-Joancomartí")
.withField(StandardField.DATE, "2018-01-19")
.withField(StandardField.HOWPUBLISHED, "Cryptology ePrint Archive, Paper 2017/1095")
.withField(StandardField.NOTE, "\\url{https://eprint.iacr.org/2017/1095}")
.withField(StandardField.TITLE, "Analysis of the Bitcoin UTXO set")
.withField(StandardField.URL, "https://eprint.iacr.org/2017/1095/20180119:113352")
.withField(StandardField.HOWPUBLISHED, "Cryptology {ePrint} Archive, Paper 2017/1095")
.withField(StandardField.TITLE, "Analysis of the Bitcoin {UTXO} set")
.withField(StandardField.URL, "https://eprint.iacr.org/archive/versions/2017/1095/20180119:113352")
.withField(StandardField.VERSION, "20180119:113352")
.withField(StandardField.YEAR, "2017");
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/jabref/logic/importer/fetcher/MedraTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ private static Stream<Arguments> getDoiBibEntryPairs() {
.withField(StandardField.DOI, "10.2143/TVF.80.3.3285690")
.withField(StandardField.ISSN, "2031-8952, 2031-8952")
.withField(StandardField.JOURNAL, "Tijdschrift voor Filosofie")
.withField(StandardField.PAGES, "625-629")
.withField(StandardField.PAGES, "625–629")
)),

Arguments.of("10.3303/CET1977146",
Expand All @@ -55,7 +55,7 @@ private static Stream<Arguments> getDoiBibEntryPairs() {
.withField(StandardField.YEAR, "2019")
.withField(StandardField.DOI, "10.3303/CET1977146")
.withField(StandardField.JOURNAL, "Chemical Engineering Transactions")
.withField(StandardField.PAGES, "871-876")
.withField(StandardField.PAGES, "871–876")
.withField(StandardField.VOLUME, "77"))),
Arguments.of("10.1400/115378",
Optional.of(
Expand Down
1 change: 0 additions & 1 deletion src/test/java/org/jabref/logic/importer/fetcher/TitleFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ void setUp() {
.withField(StandardField.BOOKTITLE, "2009 35th Euromicro Conference on Software Engineering and Advanced Applications")
.withField(StandardField.PUBLISHER, "IEEE")
.withField(StandardField.TITLE, "BPELscript: A Simplified Script Syntax for WS-BPEL 2.0")
.withField(StandardField.VOLUME, "5331")
.withField(StandardField.YEAR, "2009")
.withField(StandardField.MONTH, "#aug#")
.withField(StandardField.PAGES, "39--46")
Expand Down
15 changes: 8 additions & 7 deletions src/test/java/org/jabref/logic/importer/fetcher/isbntobibtex/GVKIsbnFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,18 @@ public void authorsAreCorrectlyFormatted() throws Exception {
BibEntry bibEntry = new BibEntry(StandardEntryType.Book)
.withField(StandardField.TITLE, "Repository")
.withField(StandardField.SUBTITLE, "Eine Einführung")
.withField(StandardField.PUBLISHER, "De Gruyter Oldenbourg")
.withField(StandardField.PUBLISHER, "Walter de Gruyter GmbH")
.withField(StandardField.AUTHOR, "Habermann, Hans-Joachim")
.withField(StandardField.ISBN, "9783110702125")
.withField(StandardField.YEAR, "2020")
.withField(StandardField.ADDRESS, "München")
.withField(StandardField.EDITION, "Reprint 2020")
.withField(StandardField.ADDRESS, "Berlin/München/Boston")
.withField(StandardField.EDITION, "1st ed.")
.withField(StandardField.EDITOR, "Frank Leymann")
.withField(StandardField.NUMBER, "8.1")
.withField(StandardField.PAGETOTAL, "1294")
.withField(StandardField.SERIES, "Handbuch der Informatik")
.withField(new UnknownField("ppn_gvk"), "1738076555");
.withField(StandardField.NUMBER, "v.8.1")
.withField(StandardField.PAGETOTAL, "1296")
.withField(StandardField.SERIES, "Handbuch der Informatik Series")
.withField(StandardField.NOTE, "Description based on publisher supplied metadata and other sources.")
.withField(new UnknownField("ppn_gvk"), "1910493767");

Optional<BibEntry> fetchedEntry = fetcher.performSearchById("9783110702125");
assertEquals(Optional.of(bibEntry), fetchedEntry);
Expand Down
Loading