Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0025-reviewdog-reviews.md #12435

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Update 0025-reviewdog-reviews.md #12435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/decisions/0025-reviewdog-reviews.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ How to quickly provide feedback to contributors that checkstyle was not matched?
## Decision Outcome

Chosen option: "Use Reviewdog's PullRequest review reporter", because resolves force to provide fast feedback.
We do not want to use `comment-failure-action`, because [it might procude too much comments](https://github.com/quipper/comment-failure-action/issues/224).
We do not want to use `comment-failure-action`, because [it might produce too many comments](https://github.com/quipper/comment-failure-action/issues/224).
We accept that newcomers might be annoyed if quick automatic feedback by a bot is given:
We value the time of our maintainers and want to keep them focused on the real challanges of the code changes.
Loading