-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Entry Editor #12210
Open
calixtus
wants to merge
21
commits into
main
Choose a base branch
from
extract-entry-editor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extract Entry Editor #12210
+249
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe21d9b
to
f247c7c
Compare
# Conflicts: # src/main/java/org/jabref/gui/frame/JabRefFrame.java
Related historic PRs:
Side note: I found the PR for the maintable JavaFX migration: #3621 (and #3591) |
There can only be one. |
Works fine for me. Although I noticed some exception logs (not related to these changes) appearing when I double click on an entry to bring up the editor after startup. |
# Conflicts: # src/main/java/org/jabref/gui/frame/JabRefFrame.java
The build of this PR is available at https://builds.jabref.org/pull/12210/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: entry-editor
component: ui
dev: code-quality
Issues related to code or architecture decisions
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having an instance of the EntryEditor for every LibraryTab - one is enough. One EntryEditor to rule them all, one EntryEditor to find them, one Entryeditor to bring them all and in the bottom of the interface bind them.
Introduced
Todo:
Move Open/Close of EntryEditor to JabRefFrameAdapt EntryEditor to follow observables and to tolerate no entryAdapt StateManager from DatabaseContext to LibraryTab? (invalid)Fix remaining bugs:Not showing anythingNPE on exitOpen entry editor menu itemEntry editor maximized when openGoal:
Level of abstraction (StateManager should use LibraryTab instead of BibDatabaseContext)postponed to later pr. would overload this one
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)