Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assign-me-action #11945

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Add assign-me-action #11945

merged 5 commits into from
Oct 14, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 13, 2024

We constantly get contributors wanting to have an issue assigned. To reduce the load, I propose the assign-issue-action. Contributors can then issue /assign-me and then they get assigned. Nice feature: After 30 days of inactivity, they get unassigned. (We can configure this time frame)

I also included text of our newcomer text.

Drawback: Our project boards are not updated accordingly. Filed as feature-wish to the action -> takanome-dev/assign-issue-action#239

Alternative .take. Seems to have the same capabilities as the chosen action. Found via https://github.com/community/maintainers/discussions/447#discussioncomment-10756193.

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/570

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

github-actions[bot]

This comment was marked as outdated.

Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/11945/merge.

@HoussemNasri
Copy link
Member

HoussemNasri commented Oct 13, 2024

Drawback: Our project boards are not updated accordingly. Filed as feature-wish to the action -> takanome-dev/assign-issue-action#239

We can have it mention @JabRef/developers after assignment as a notification to manually update the project status?

About the feature request, I don't think it is the responsibility of the assign-issue-action to update the project status, maybe a separate action would be responsible for listening for assignment status changes and acting on it. I don't know if it is possible though, I remember seeing @ThiloteE commenting on why it's not possible to automatically update project status.

@ThiloteE
Copy link
Member

Only default Github Projects does not offer the feature of automatically update the project status upon assignment or pull-request. Maybe there is a GitHub action out there that can do it, but I have not been actively recently.

Problems I see with automatic assignment:

  1. Students don't know how to trigger it.
  2. Students will trigger it, even though other students are already assigned to a project.

I think it could be nice to know if somebody asks for assignment, that would make it much easier to focus on the assignment and I would not have to look at 100 other e-mails everyday just to find the ones that ask for an assignment.

I am in favour of a separate notification for people that ask for assignment. I am not in favour of automating assignment.

@ThiloteE
Copy link
Member

Some issues have been tagged automatically, even though they are already assigned. What to do with it? Have you done this for testing?
image

@koppor
Copy link
Member Author

koppor commented Oct 14, 2024

Some issues have been tagged automatically, even though they are already assigned. What to do with it? Have you done this for testing?

I assigned the label by hand. With that label in place, the student will get unassigned after 30 days. 😅

@koppor
Copy link
Member Author

koppor commented Oct 14, 2024

Only default Github Projects does not offer the feature of automatically update the project status upon assignment or pull-request.

Therefore, I posted the issue takanome-dev/assign-issue-action#239.

Maybe there is a GitHub action out there that can do it, but I have not been actively recently.

Maybe, even their API does not allow. Indication: gh issue edit does not allow for setting states to a project.

Problems I see with automatic assignment:

1. Students don't know how to trigger it.

Thefore, I added it to the CONTRIBUTING.md.

image

https://github.com/JabRef/jabref/blob/add-assign-action/CONTRIBUTING.md

We still have the manual way to do it.

2. Students will trigger it, even though other students are already assigned to a project.

For this case, the action posts a comment posted when a user tries to assign themselves to an issue that is already assigned.

I think it could be nice to know if somebody asks for assignment, that would make it much easier to focus on the assignment and I would not have to look at 100 other e-mails everyday just to find the ones that ask for an assignment.

This is more an LLM task to convert to "text" to "assign" or "NOOP". We could have an LLM running which posts /assign-commenter (refs takanome-dev/assign-issue-action#240) in case it is sure the student asks for an assignmetn.

I am in favour of a separate notification for people that ask for assignment. I am not in favour of automating assignment.

Let's discuss in the devcall. - I like most the unassignment feature of the action. For the assignment I tend to like to - to reduce load on our side.

@koppor
Copy link
Member Author

koppor commented Oct 14, 2024

Drawback: Our project boards are not updated accordingly. Filed as feature-wish to the action -> takanome-dev/assign-issue-action#239

We can have it mention @JabRef/developers after assignment as a notification to manually update the project status?

Too much noise for the developers. We could have another group @JabRef/curators (or assigners? or maintainers?) being notified.

About the feature request, I don't think it is the responsibility of the assign-issue-action to update the project status, maybe a separate action would be responsible for listening for assignment status changes and acting on it. I don't know if it is possible though, I remember seeing @ThiloteE commenting on why it's not possible to automatically update project status.

It seems to lead to a complex GraphQL query: https://stackoverflow.com/a/77799377/873282

There is a kind of action moving in the precense of a label: https://github.com/marketplace/actions/move-issue-to-project-column. If the absence of a label also worked (refs m7kvqbe1/github-action-move-issues#1), it would be exactly what we search for.


Notes:

@koppor koppor mentioned this pull request Oct 14, 2024
6 tasks
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/11945/merge.

@koppor
Copy link
Member Author

koppor commented Oct 14, 2024

DevCall: We try out.

@koppor koppor added this pull request to the merge queue Oct 14, 2024
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/11945/merge.

Merged via the queue into main with commit 9bab910 Oct 14, 2024
26 checks passed
@koppor koppor deleted the add-assign-action branch October 14, 2024 20:03
Copy link
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
* Add assign-me-action

* Fix linting issues.

* Fix grammar

* Add reaction on 📍 Assigned
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
* Add assign-me-action

* Fix linting issues.

* Fix grammar

* Add reaction on 📍 Assigned
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 21, 2024
* Add assign-me-action

* Fix linting issues.

* Fix grammar

* Add reaction on 📍 Assigned
@koppor koppor mentioned this pull request Oct 23, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants