-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TeXworks #10953
Add support for TeXworks #10953
Conversation
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com> Co-Authored-By: LACHIRI ILIAS <67273129+lachiri-ilias@users.noreply.github.com>
Updated changelong to reflect changes.
Co-Authored-By: Vlad Dobre <29517124+vladdobre@users.noreply.github.com> Co-Authored-By: Kr1st1an-F <100246316+kr1st1an-f@users.noreply.github.com>
…rite JabRef#3197 Co-Authored-By: Vlad Dobre <29517124+vladdobre@users.noreply.github.com> Co-Authored-By: Kr1st1an-F <100246316+kr1st1an-f@users.noreply.github.com>
In the prefs we have some autodetect logic
|
This is a bit weird. I thought the we used the autodetect logic correctly. We tried reseting the settings to the defaults but it still finds the path. My default path is in Program Files (x86). |
I have MikTeX installed somewhere else. OK for me that I manually need to set the path However when I click Save in the preferences, there should be a check. If the binary could not be found, user should be asked to navigate to the options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the TODO with the icon. Can you work on this?
We couldn't find this behavior for the other editors, maybe this should be a separate issue ? |
@calixtus will continue working on this PR today. Some architecture changes etc. For instance, at |
|
We have added the PushToTeXworks class, which is an implementation of AbstractPushToApplication. This class contains the code for pushing an entry to TeXworks. A call to this class has been added in PushToApplications. In JabRefPreferences we have added the option of TeXworks with PushToApplications.TEXWORKS.
The icon is set to the default one, as it is mentioned here ("Add an icon (ask maintainers for licensed/free svg) to the JabRefIcon ttf font (This will be a task for JabRef maintainers) in the meantime use a simple default icon") that maintainers will update the default icon.
Closes #3197
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)