Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fetcherName with Identifier-based Web Search #10391

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Replace fetcherName with Identifier-based Web Search #10391

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21e69c7
Replace fetcherName with Identifier-based Web Search
Luggas4you Sep 17, 2023
0eb73b0
Add l10n
Luggas4you Sep 21, 2023
4ff29c2
Merge branch 'main' into websearch-name
koppor Sep 21, 2023
b537931
Merge branch 'main' into websearch-name
koppor Sep 21, 2023
a50068d
Add Localization.lang(...)
koppor Sep 22, 2023
e3d48f4
Add CHANGELOG.md entry
koppor Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public void search() {
if (CompositeIdFetcher.containsValidId(query)) {
CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences());
parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query)));
fetcherName = compositeIdFetcher.getName();
fetcherName = "Identifier-based Web Search";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have this localized as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to l10n

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-directed learning comment: https://devdocs.jabref.org/code-howtos/localization.html

Direct comment: You forgot to put Localization.lang(...) around. JabRef has no magic to determine translation strings.

}

final String finalFetcherName = fetcherName;
Expand Down