Add entry based on ISSN number #10124

src/main/java/org/jabref/gui/fieldeditors/identifier/ISSNIdentifierEditorViewModel.java

@@ -0,0 +1,24 @@
+package org.jabref.gui.fieldeditors.identifier;
+
+import org.jabref.gui.DialogService;
+import org.jabref.gui.JabRefGUI;
+import org.jabref.gui.autocompleter.SuggestionProvider;
+import org.jabref.gui.mergeentries.FetchAndMergeEntry;
+import org.jabref.gui.util.TaskExecutor;
+import org.jabref.logic.integrity.FieldCheckers;
+import org.jabref.model.entry.BibEntry;
+import org.jabref.model.entry.field.StandardField;
+import org.jabref.model.entry.identifier.ISSN;
+import org.jabref.preferences.PreferencesService;
+
+public class ISSNIdentifierEditorViewModel extends BaseIdentifierEditorViewModel<ISSN> {
+    public ISSNIdentifierEditorViewModel(SuggestionProvider<?> suggestionProvider, FieldCheckers fieldCheckers, DialogService dialogService, TaskExecutor taskExecutor, PreferencesService preferences) {
+        super(StandardField.ISSN, suggestionProvider, fieldCheckers, dialogService, taskExecutor, preferences);
+        configure(true, false);
+    }
+
+    @Override
+    public void fetchBibliographyInformation(BibEntry bibEntry) {
+        new FetchAndMergeEntry(JabRefGUI.getMainFrame().getCurrentLibraryTab(), taskExecutor, preferences, dialogService).fetchAndMerge(entry, field);
+    }
+}

src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java

@@ -45,6 +45,8 @@ public IdentifierEditor(Field field,
             this.viewModel = new ISBNIdentifierEditorViewModel(suggestionProvider, fieldCheckers, dialogService, taskExecutor, preferences);
         } else if (StandardField.EPRINT == field) {
             this.viewModel = new EprintIdentifierEditorViewModel(suggestionProvider, fieldCheckers, dialogService, taskExecutor, preferences);
+        } else if (StandardField.ISSN == field) {
+            this.viewModel = new ISSNIdentifierEditorViewModel(suggestionProvider, fieldCheckers, dialogService, taskExecutor, preferences);
         } else {
             throw new IllegalStateException(String.format("Unable to instantiate a view model for identifier field editor '%s'", field.getDisplayName()));
         }

src/main/java/org/jabref/logic/importer/fetcher/IssnFetcher.java

@@ -37,7 +37,7 @@ public IssnFetcher(ImportFormatPreferences importFormatPreferences) {
     public Optional<BibEntry> performSearchById(String identifier) throws FetcherException {
 
         Optional<String> checkedId = issnChecker.checkValue(identifier);
-        if (checkedId.isPresent()) {
+        if (checkedId.equals(Optional.empty())) {
             String queryString = concatenateIssnWithId(identifier);
             List<BibEntry> bibEntries = doajFetcher.performSearch(queryString);
             return bibEntries.stream().findFirst();

src/test/java/org/jabref/logic/importer/fetcher/IssnFetcherTest.java

@@ -6,13 +6,16 @@
 import org.jabref.logic.importer.ImportFormatPreferences;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.field.StandardField;
+import org.jabref.model.entry.types.StandardEntryType;
+import org.jabref.preferences.BibEntryPreferences;
 import org.jabref.testutils.category.FetcherTest;
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 
 @FetcherTest
 class IssnFetcherTest {
@@ -21,9 +24,13 @@ class IssnFetcherTest {
     private BibEntry bibEntry;
     @BeforeEach
     void setUp() {
-        fetcher = new IssnFetcher(mock(ImportFormatPreferences.class));
+        ImportFormatPreferences importPrefs = mock(ImportFormatPreferences.class);
+        BibEntryPreferences bibEntryPrefs = mock(BibEntryPreferences.class);
+        when(importPrefs.bibEntryPreferences()).thenReturn(bibEntryPrefs);
 
-        bibEntry = new BibEntry(BibEntry.DEFAULT_TYPE)
+        fetcher = new IssnFetcher(importPrefs);
+
+        bibEntry = new BibEntry(StandardEntryType.Article)
                 .withField(StandardField.ISSN, "2579-5341")
                 .withField(StandardField.TITLE, "Query: Jurnal Sistem Informasi")
                 .withField(StandardField.INSTITUTION, "Univesitas Islam Negeri Sumatera Utara, Fakultas Sains dan Teknologi, Program Studi Sistem Informasi")
@@ -33,7 +40,7 @@ void setUp() {
 
     @Test
     void performSearchById() throws FetcherException {
-        Optional<BibEntry> fetchedEntry = fetcher.performSearchById("1662-4548");
+        Optional<BibEntry> fetchedEntry = fetcher.performSearchById("2579-5341");
         assertEquals(Optional.of(bibEntry), fetchedEntry);
     }