Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when closing a library with groups #10005

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

aqurilla
Copy link
Contributor

This fixes #9997 by adding null checks for the root node of groupTree.
No further exceptions are observed in the log when closing a library with groups

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@aqurilla aqurilla marked this pull request as ready for review June 12, 2023 00:48
@Siedlerchr
Copy link
Member

LGTM just add a quick note in the changelog. I don't know if it was present in 5.9 or not, but in any way helpful to have it listed as fixed

@Siedlerchr Siedlerchr closed this Jun 12, 2023
@Siedlerchr Siedlerchr reopened this Jun 12, 2023
Siedlerchr
Siedlerchr previously approved these changes Jun 12, 2023
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 12, 2023
@koppor
Copy link
Member

koppor commented Jun 12, 2023

In main, I sometimes had to click the close button at a tab twice. This is now solved, too.

@koppor koppor merged commit 5018f63 into JabRef:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: groups status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when closing a library with groups
4 participants