Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to set EtAlString empty #1841

Closed
ph0boss opened this issue Aug 24, 2016 · 6 comments
Closed

Impossible to set EtAlString empty #1841

ph0boss opened this issue Aug 24, 2016 · 6 comments

Comments

@ph0boss
Copy link

ph0boss commented Aug 24, 2016

JabRef version 3.5

Steps to reproduce:

  1. Use a style with Authors formatting as follows:
    article=\format[Authors(LastFirst,Initials,FullPunc,1,1,EtAl=)]{\author}
    In this example EtAlString is set to be empty.
  2. Use it to cite something.
  3. Author is formatted as follows:
    Surname, N. et al.

example_style.jstyle.zip

@oscargus
Copy link
Contributor

Thanks for the report. I can confirm that there is code prohibiting setting the string empty. However, as there seems to (at least) one use case and I do not really see why it should be prohibited, there is a fixed version in https://builds.jabref.org/fix1841/ in five minutes. Please try it out.

@oscargus
Copy link
Contributor

I close this as we merged the fix. Feel free to reopen it if it doesn't work. (3.6 will be released tomorrow and should include it.)

Siedlerchr added a commit that referenced this issue Aug 25, 2016
* master:
  Disable incompatible properties for shared database. (#1826)
  Allow setting the etal-string empty. Implements #1841 (#1848)
  fix SplitPaneChangeListener (#1840)
  French localization: Jabref_fr: empty strings translated (#1847)
  Fixes #1687 "month" field ascending/descending sorting swapped (#1837)
  Fix localization entry.
  Update German translation (#1829)
  entry scrolling  didn't work if the entry in question was just 1 row outside the table (bottom) (<; <= mistake)
  fix indent
  when pasting an entry search the entry from the back, b/c we want to select the duplicate, not the original
  fix issues and delete a duplicate method
  when inserting a duplicate the right entry will be selected
@ph0boss
Copy link
Author

ph0boss commented Aug 25, 2016

Maybe it works.. I couldn't try it because select style button doesn't work. Nothing happens when I press it. I tried both the link you provided and the latest master. Fedora 25 64bit.
Running as $ java -jar ./JabRef-3.6dev--snapshot--2016-08-25--master--40ae061.jar
Should I file another bug report about this issue?

@oscargus
Copy link
Contributor

Strange... I'll have to look into that. As it is (should be) unrelated to this, it would be great if you can file a new bug report, although I'll still hopefully remember it for tonight.

@oscargus
Copy link
Contributor

OK, I think I found the problem. If you add a "default" style you should be able to test it (unless you have it already, but when I tried you example I got an error from not having a style for default, only article). I'll try to fix that problem in the source so that it behaves slightly better, at least shows a dialog instead of throwing errors.

@ph0boss
Copy link
Author

ph0boss commented Aug 25, 2016

Yeah, now both issues are fixed. Thanx for such quick help!

ayanai1 pushed a commit to ayanai1/jabref that referenced this issue Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants