Make file renaming dialog resizable

[ryan-carpenter]

Is your suggestion for improvement related to a problem? Please describe.
The text field for renaming files is usually too small to show the whole file name. This makes it hard to edit the file name, because the dialog is not resizable. Screen scaling does not matter for 38x40x2160 at 150% or 200% (default font set to 11 pts).

Describe the solution you'd like
Make the file-rename dialog wider and/or resizable to enable easier viewing and editing.

Additional context

[Niharika0612]

I would like to pick this up.

[github-actions]

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[Niharika0612]

hi, I am getting this issue

org.jabref.logic.citationstyle.CitationStyleTest > numericPropertyMatches(boolean, String) [1] true, ieee.csl FAILED

  org.opentest4j.AssertionFailedError: Citation style not found: ieee.csl ==> expected: <true> but was: <false>

org.jabref.logic.citationstyle.CitationStyleTest > numericPropertyMatches(boolean, String) [2] false, apa.csl FAILED

  org.opentest4j.AssertionFailedError: Citation style not found: apa.csl ==> expected: <true> but was: <false>

org.jabref.logic.citationstyle.CitationStyleTest > numericPropertyMatches(boolean, String) [3] true, vancouver.csl FAILED

  org.opentest4j.AssertionFailedError: Citation style not found: vancouver.csl ==> expected: <true> but was: <false>

org.jabref.logic.citationstyle.CitationStyleTest > numericPropertyMatches(boolean, String) [4] false, chicago-author-date.csl FAILED

  org.opentest4j.AssertionFailedError: Citation style not found: chicago-author-date.csl ==> expected: <true> but was: <false>

org.jabref.logic.citationstyle.CitationStyleTest > numericPropertyMatches(boolean, String) [5] true, nature.csl FAILED

  org.opentest4j.AssertionFailedError: Citation style not found: nature.csl ==> expected: <true> but was: <false>

When i am trying to run the project on my local system.

[Niharika0612]

i have checked already and all the files are updates with the main repo

[koppor]

@Niharika0612 please try https://devdocs.jabref.org/code-howtos/faq.html#orgjabreflogiccitationstylecitationstyle-discovercitationstyles-error-could-not-find-any-citation-style-tried-with-ieeecsl

[Niharika0612]

I tried, and it said to execute these commands, which i did

But my csl-styles and the csl-locales files come up empty. i checked the past history, but i have not made any changes in the file. How do i get the files in this case?

[Siedlerchr]

Go int the "jabref" directory, open a terminal and run "git submodule init" and then "git submodule update"

[Niharika0612]

the csl-styles folder still doesn't work

[ThiloteE]

Does the following help? git submodule deinit -f . then git submodule update --init --recursive.

[Siedlerchr]

that looks like you had some connection issuses

[subhramit]

But my csl-styles and the csl-locales files come up empty. i checked the past history, but i have not made any changes in the file. How do i get the files in this case?

Hi @Niharika0612. Did you follow the steps to set up a local development environment? Did you use the --recurse-submodules flag when cloning the repository, as mentioned?

[Niharika0612]

But my csl-styles and the csl-locales files come up empty. i checked the past history, but i have not made any changes in the file. How do i get the files in this case?

Hi @Niharika0612. Did you follow the steps to set up a local development environment? Did you use the --recurse-submodules flag when cloning the repository, as mentioned?

I missed this. I executed this again, so now all the files are here.

[Niharika0612]

How do i resolve this error? I updates my antler version, but it still does not work.

[subhramit]

How do i resolve this error? I updates my antler version, but it still does not work.

Check out the developer FAQs:

https://devdocs.jabref.org/code-howtos/faq.html#bstvmvisitorjava157-error-package-bstparser-does-not-exist

[Niharika0612]

How do i resolve this error? I updates my antler version, but it still does not work.

Check out the developer FAQs:

https://devdocs.jabref.org/code-howtos/faq.html#bstvmvisitorjava157-error-package-bstparser-does-not-exist

the BstBaseVisitor (which is supposed to be derived from the antlr) is also missing from the Bst.g4 ( which is inside the antlr ) and there is no provision in the FAQs for this. if anyone knows how do i get/derive/find the BstBaseVisitor class ?

[Niharika0612]

Anyone has any ideas?

[Siedlerchr]

Did you run gralde clean and gradle assemble

[Niharika0612]

Did you run gralde clean and gradle assemble

Yes I did, but the error still remains. Any idea where the BstBaseVisitor class is supposed to be?
i thought antlr will handle that class, but no such thing happened.

[subhramit]

Yes I did, but the error still remains. Any idea where the BstBaseVisitor class is supposed to be? i thought antlr will handle that class, but no such thing happened.

I suggest that you do a clean set-up from scratch. Follow each and every step carefully mentioned in the devdocs for setting up. Ideally, if you do so, you should be able to get it up and running.

You can also ask questions on the gitter chat.

[Niharika0612]

How do i resolve this error? I updates my antler version, but it still does not work.

Check out the developer FAQs:
https://devdocs.jabref.org/code-howtos/faq.html#bstvmvisitorjava157-error-package-bstparser-does-not-exist

the BstBaseVisitor (which is supposed to be derived from the antlr) is also missing from the Bst.g4 ( which is inside the antlr ) and there is no provision in the FAQs for this. if anyone knows how do i get/derive/find the BstBaseVisitor class ?

yeah, i think so too, though i was thinking if there was a chance to do so, without starting from scratch

[Niharika0612]

How do i recreate this error in my system?

[Satyamkumarnavneet]

Hey @koppor, I am not able to find the code snippet to fix this issue. Could you please help me?

[Satyamkumarnavneet]

Hi @koppor, I hope you're doing well. I've been reviewing the code, but I'm having trouble locating the specific section. Could you please provide some guidance or share any relevant documentation that might help me better understand the codebase? Additionally, I would appreciate it if you could assign me this issue. Thank you for your assistance!

[koppor]

Its some JavaFX.

Note that you can search for an arbitrary string in the code using Ctrl+Shift+F. Maybe that helps to locate some code.

[Satyamkumarnavneet]

Hi @koppor,

I've resolved the issue, and the file renaming dialog has been updated as follows:

• Larger Dialog: The dialog is now wide enough to accommodate long file names, making renaming much easier.
• Resizable Dialog: Added setResizable(true) to allow users to resize the dialog as per their needs, providing flexibility across different screen sizes and resolutions.

You can see the updated functionality in the attached screenshot. Please assign this issue to me so I can open a pull request if these changes look good to you.

[github-actions]

👋 Hey @Satyamkumarnavneet, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

[Satyamkumarnavneet]

/assign-me

[github-actions]

👋 Hey @Satyamkumarnavneet, this issue is already assigned to @Niharika0612.

Note

⏳ If the issue isn't closed within ** days**, it will be automatically unassigned.
A maintainer can also add you to the list of assignees or swap you with the current assignee.

[koppor]

Hi @koppor,

I've resolved the issue, and the file renaming dialog has been updated as follows:

• Larger Dialog: The dialog is now wide enough to accommodate long file names, making renaming much easier.
• Resizable Dialog: Added setResizable(true) to allow users to resize the dialog as per their needs, providing flexibility across different screen sizes and resolutions.

You can see the updated functionality in the attached screenshot. Please assign this issue to me so I can open a pull request if these changes look good to you.

I don't see any pull request

[github-actions]

👋 Hey @koppor, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

[Satyamkumarnavneet]

Hi @koppor,
I've resolved the issue, and the file renaming dialog has been updated as follows:

• Larger Dialog: The dialog is now wide enough to accommodate long file names, making renaming much easier.
• Resizable Dialog: Added setResizable(true) to allow users to resize the dialog as per their needs, providing flexibility across different screen sizes and resolutions.

You can see the updated functionality in the attached screenshot. Please assign this issue to me so I can open a pull request if these changes look good to you.

I don't see any pull request

Apologies for the confusion! I hadn’t submitted the pull request earlier. I’ve now created the pull request with the changes implemented. You can check it here.

[github-actions]

👋 Hey @Satyamkumarnavneet, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

[subhramit]

Hey @Satyamkumarnavneet , welcome to JabRef and congratulations on your first contribution!

• Larger Dialog: The dialog is now wide enough to accommodate long file names, making renaming much easier.
• Resizable Dialog: Added setResizable(true) to allow users to resize the dialog as per their needs, providing flexibility across different screen sizes and resolutions.

I'd like to point out certain guidelines that we like to follow here so that you are aware in your journey ahead.

We will provide feedback on your work soon.

[Satyamkumarnavneet]

Hi @subhramit, thank you for the warm welcome and for highlighting my first contribution! I look forward to your feedback and appreciate the shared guidelines to help me align better with the project.

[koppor]

@Satyamkumarnavneet The PR #12390 was closed automatically, because you deleted the branch. - Do you intend to work on this?

Maybe it is as easy as

inputDialog.setResizable(true);

Don't forget to add a CHANGELOG.md entry.

If you do not want to continue on this, it is also fine.

[Satyamkumarnavneet]

@Satyamkumarnavneet The PR #12390 was closed automatically, because you deleted the branch. - Do you intend to work on this?

Maybe it is as easy as

inputDialog.setResizable(true);

Don't forget to add a CHANGELOG.md entry.

If you do not want to continue on this, it is also fine.

The changes are complete. Please review them at your convenience.