-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Push application (Lyx,SublimeText,Texmaker,TeXstudio,Vim,WinEdt,TexShop) #10941
Comments
I see, but it's not straightforward to have tests as these interact with external programs on the system and require the editors to be installed on the system. However, the only thing I would try is to check if the generated command is correctly generated, e.g. if the citation string is correctly generated with prefix + key + suffix
And I just see that PushToLyx for example is missing the prefix and suffix |
Adding tests is kind of "integration test". An X server needs to be started. We do that for jabref/.github/workflows/tests.yml Line 245 in 62ee331
The test needs to do following:
"example.tex" can be an empty file at step 2. Steps 2 and 4 can be very difficult from a command line. I expect 10 to 20 hours per tool to find out how to automate. Thus, I agree with the comment at #10941 (comment) so that the generated string is correct. |
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com> Co-Authored-By: LACHIRI ILIAS <67273129+lachiri-ilias@users.noreply.github.com>
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com> Co-Authored-By: LACHIRI ILIAS <67273129+lachiri-ilias@users.noreply.github.com>
If this would be of any use, in SublimeText commands may be run from CLI:
The |
I close this issue as this is neither a user-facing issue nor something reported by the maintainers of JabRef. Nevertheless, thank you for choosing JabRef. |
Me and my group (@Blezie, @JohannBiorck @vladdobre @Kr1st1an-F) are currently working on the Issue (#3191 TeXworks). We are currently writing tests for this issue.
We have noticed that all the push method (Lyx, SublimeText, Texmaker, TeXstudio, Vim, WinEdt, TexShop) doesn't contain test and they are very similar. So we wonder if we can contribute to create these tests ?
The text was updated successfully, but these errors were encountered: