Add unchecking files after import in UnlinkedFilesDialogViewModel.java

- Remove usage of containsEntryWithLinkedFile in UnlinkedFilesDialogView.java
JabRef · Feb 16, 2025 · b61afce · b61afce
1 parent 798bda5
commit b61afce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogView.java b/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogView.java
@@ -269,6 +269,9 @@ void scanFiles() {
     @FXML
     void startImport() {
         viewModel.startImport();
+
+        // Uncheck selected files
+        unlinkedFilesList.getCheckModel().clearChecks();
     }
 
     @FXML

diff --git a/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModel.java b/src/main/java/org/jabref/gui/externalfiles/UnlinkedFilesDialogViewModel.java
@@ -7,7 +7,6 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.StandardOpenOption;
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
 import java.util.function.Predicate;
@@ -43,7 +42,6 @@
 import org.jabref.logic.util.StandardFileType;
 import org.jabref.logic.util.TaskExecutor;
 import org.jabref.model.database.BibDatabaseContext;
-import org.jabref.model.entry.LinkedFile;
 import org.jabref.model.util.FileUpdateMonitor;
 
 import de.saxsys.mvvmfx.utils.validation.FunctionBasedValidator;
@@ -146,22 +144,19 @@ public void startSearch() {
     }
 
     public void startImport() {
-        List<Path> fileList = new ArrayList<>(checkedFileListProperty
+        List<Path> fileList = checkedFileListProperty
                 .stream()
                 .map(TreeItem::getValue)
                 .map(FileNodeViewModel::getPath)
                 .filter(Files::isRegularFile)
-                .toList());
+                .toList();
 
         if (fileList.isEmpty()) {
             LOGGER.warn("There are no valid files checked for import");
             return;
         }
         resultList.clear();
 
-        // Removes duplicate files before importing
-        fileList.removeIf(path -> bibDatabase.getDatabase().containsEntryWithLinkedFile(new LinkedFile(path)));
-
         importFilesBackgroundTask = importHandler
                 .importFilesInBackground(fileList, bibDatabase, preferences.getFilePreferences(), TransferMode.LINK)
                 .onRunning(() -> {