Fixes #4544 Do not extract file ending from Urls

JabRef · Dec 21, 2018 · 725ce6a · Siedlerchr · Dec 22, 2018 · 725ce6a
1 parent 949d204
commit 725ce6a
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/src/main/java/org/jabref/model/util/FileHelper.java b/src/main/java/org/jabref/model/util/FileHelper.java
@@ -1,5 +1,6 @@
 package org.jabref.model.util;
 
+import java.net.URL;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -31,6 +32,10 @@ public static Optional<String> getFileExtension(Path file) {
      * @return The extension (without leading dot), trimmed and in lowercase.
      */
     public static Optional<String> getFileExtension(String fileName) {
+        if (isUrl(fileName)) {
+            return Optional.empty();
+        }
+
         int dotPosition = fileName.lastIndexOf('.');
         if ((dotPosition > 0) && (dotPosition < (fileName.length() - 1))) {
             return Optional.of(fileName.substring(dotPosition + 1).trim().toLowerCase(Locale.ROOT));
@@ -129,4 +134,13 @@ private static Optional<Path> expandFilename(String filename, Path directory) {
             return Optional.empty();
         }
     }
+
+    private static boolean isUrl(String url) {
+        try {
+            new URL(url);
+            return true;
+        } catch (Exception e) {
+            return false;
+        }
+    }
 }