Merge pull request #12414 from JabRef/fixui

Fix number column hits by adding css selectors
JabRef · Jan 25, 2025 · 2381079 · 2381079
2 parents df438b8 + f345fd5
commit 2381079
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,6 +21,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We fixed an issue where new entries were inserted in the middle of the table instead of at the end. [#12371](https://github.com/JabRef/jabref/pull/12371)
 - We fixed an issue where removing the sort from the table did not restore the original order. [#12371](https://github.com/JabRef/jabref/pull/12371)
 - We fixed an issue where JabRef icon merges with dark background [#7771](https://github.com/JabRef/jabref/issues/7771)
+- We fixed an issue where an entry's group was no longer highlighted on selection [#12413](https://github.com/JabRef/jabref/issues/12413)
 
 ### Removed
 

diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css
@@ -664,13 +664,7 @@ TextFlow > .tooltip-text-monospaced {
     -fx-padding: 0 0 0 0;
 }
 
-.numberColumn > .hits:any-selected {
-    -fx-background-color: derive(-jr-green, 70%);
-}
 
-.numberColumn > .hits:all-selected {
-    -fx-background-color: -jr-green;
-}
 
 .table-view,
 .tree-table-view {
@@ -2037,6 +2031,14 @@ We want to have a look that matches our icons in the tool-bar */
     -fx-fill: -jr-group-hits-fg;
 }
 
+#groupTree .numberColumn > .hits:any-selected {
+    -fx-background-color: derive(-jr-green, 70%);
+}
+
+#groupTree .numberColumn > .hits:all-selected {
+    -fx-background-color: -jr-green;
+}
+
 #groupTree .expansionNodeColumn {
     -fx-alignment: top-right;
 }

diff --git a/src/main/java/org/jabref/gui/Dark.css b/src/main/java/org/jabref/gui/Dark.css
@@ -153,11 +153,11 @@
     -fx-background-color: -fx-light-text-color, -fx-control-inner-background;
 }
 
-.numberColumn > .hits:any-selected {
+#groupTree .numberColumn > .hits:any-selected {
     -fx-background-color: derive(-jr-gray-3, 25%);
 }
 
-.numberColumn > .hits:all-selected {
+#groupTree .numberColumn > .hits:all-selected {
     -fx-background-color: -jr-gray-3;
 }