Support multiple lists for an IN clause #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnEmortalKid
commented
Jun 19, 2020
| | token=<S_CHAR_LITERAL> { rightExpression = new StringValue(token.image); } | ||
| | "(" (LOOKAHEAD(3) rightItemsList=SubSelect() | rightItemsList=SimpleExpressionList() ) ")") | ||
| ( | ||
| // syntactic lookahead for a multi expression list, ie: ((a,b),(c,d)) |
There was a problem hiding this comment.
I read through the options for lookahead and this seemed pretty nifty: https://javacc.github.io/javacc/tutorials/lookahead.html#syntactic
There was a problem hiding this comment.
However, if the potential performance hit from this is a concern, I can try to use a LOOKAHEAD(2, "(" "(") and see how that works.
There was a problem hiding this comment.
Or a vanilla plain LOOKAHEAD(3) multiExpressionList = MultiInExpressions() also works.
|
@wumpz thank you 👏 , I can go back through some issues and see which other ones could be closed by this! |
This was referenced Jun 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737
Fixes #953