Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for truncate table #719

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Add support for truncate table #719

merged 1 commit into from
Dec 6, 2018

Conversation

sarxos
Copy link
Contributor

@sarxos sarxos commented Dec 4, 2018

Hello @JSQLParser team!

At the very beginning I would like to thank you for supporting this awesome framework! I spent hours to compile ANTLR grammars for MySQL to finally drop it because it was unable to do what I needed. The JSqlParser, from the other hand, did a job marvellously!

This pull request is to fix small problem I found when working with TablesNamesFinder.

@coveralls
Copy link

coveralls commented Dec 4, 2018

Coverage Status

Coverage increased (+0.03%) to 82.887% when pulling 476209c on sarxos:patch-1 into 4da4f13 on JSQLParser:master.

Copy link
Member

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice. Thx for supporting Jsqlparser.

@sarxos
Copy link
Contributor Author

sarxos commented Dec 5, 2018

@wumpz Unit test added.

@wumpz
Copy link
Member

wumpz commented Dec 5, 2018

Do you mind if I make a squash & merge or do you want to squash your commits by your own? However the PR is OK and I will merge it.

@sarxos
Copy link
Contributor Author

sarxos commented Dec 5, 2018

@wumpz I can squash. No problem.

@wumpz wumpz merged commit 11be715 into JSQLParser:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants