Supporting Oracle operators like '>=' or '<=' with embedded whitespace. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: * Modifying the JJT syntax to support the 'space in the middle' versions of operators (any quantity of whitespace is supported). * Modifying the various operators to inherit from a new 'ComparisonOperator' class, which handles the (previously NotEqualsTo- only) logic for capturing the form of the operator. * Giving each of the various operators a constructor that accepts the syntax used. * Modifying TestUtils to strip comments out before comparing SQL text (necessary because condition07.sql is now passing, and has a comment). * Updating SpecialOracleTest to indicate 130 tests passing now (condition7.sql now passes). * Adding a new test specifically for operators into SpecialOracleTest. NOTE: Because the "! =" form of the 'not equals' operator means something different in PostgresSQL (factorial of previous argument + equals), we do NOT include that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to have operators like '>=' or '<=' separated by a space.
This includes:
NOTE: Because the "! =" form of the 'not equals' operator means something different in PostgresSQL (factorial of previous argument + equals), we do NOT include that case.