Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted fixes to the Java CC Parser definition #1153

Merged
merged 5 commits into from
Apr 16, 2021

Conversation

manticore-projects
Copy link
Contributor

@manticore-projects manticore-projects commented Apr 9, 2021

Implement Oracle Hints for INSERT, UPDATE, MERGE, DELETE

@coveralls
Copy link

coveralls commented Apr 9, 2021

Coverage Status

Coverage increased (+0.02%) to 88.501% when pulling 805c951 on manticore-projects:master into e95f6ce on JSQLParser:master.

Add test case for MergeInsert WHERE expression
@manticore-projects manticore-projects changed the title Implement Oracle Hints for INSERT, UPDATE, MERGE, DELETE Assorted fixes to the Java CC Parser definition Apr 13, 2021
Copy link
Member

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thx for the changes. Next time try to keep one improvement in one PR.

@wumpz wumpz merged commit 5ee6ec9 into JSQLParser:master Apr 16, 2021
@manticore-projects
Copy link
Contributor Author

Next time try to keep one improvement in one PR.

Actually I split it on purpose because I was not too sure how you would like the Oracle specific change. I did not want to jeopardize the simple correction waiting in the queue.

Thank you for merging and best regards
Viele Gruesse aus Thailand.

@wumpz
Copy link
Member

wumpz commented Apr 16, 2021

If you use the syntax fixes #id then Github will automatically close this issue.

@wumpz
Copy link
Member

wumpz commented Apr 17, 2021

And: viele Grüße zurück ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants