Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subjoin allows only one inner join, this should be a list #563

Closed
fjalvingh opened this issue Jan 4, 2018 · 1 comment
Closed

subjoin allows only one inner join, this should be a list #563

fjalvingh opened this issue Jan 4, 2018 · 1 comment

Comments

@fjalvingh
Copy link
Contributor

A join like

select ...
from ((select ...) join (select ...) join (select...))

is not possible in the current grammar because subjoin is defined to have only one join item. This is wrong and causes more complex SQL (like mine, sadly enough) to fail ;)

The solution is to make SubJoin have a List and to have the grammar parse that using JoinsList(). I will submit a pull request to fix this issue.

@wumpz
Copy link
Member

wumpz commented Jan 5, 2018

Could you give a concrete example.

wumpz pushed a commit that referenced this issue Feb 2, 2018
#564)

* Fix issue #563: subjoin allows only one inner join, this should be a list

* Fix failing Oracle tests because of confusion between subjoin and subselect.
@wumpz wumpz closed this as completed Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants