Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render debug data and visuals after actor's pose is updated #1161

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

seanmcleod
Copy link
Member

Based on the discussion in #1160 it was determined that the debug data strings and lines for gear positions etc. were being rendered before the actor's pose had been updated for the latest frame. Which meant the debug data would be displaying slightly out of date data causing potential confusion.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.13%. Comparing base (8e4803b) to head (2f177d9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   25.13%   25.13%           
=======================================
  Files         170      170           
  Lines       18330    18330           
=======================================
  Hits         4608     4608           
  Misses      13722    13722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gallonmate
Copy link
Contributor

Great find! Tested and works.

@bcoconni
Copy link
Member

Thanks for the PR, @seanmcleod. Just a tiny comment: the indent seems different after than it was before. Some tabs changed to spaces during copy/pasting or something like that ?

@seanmcleod
Copy link
Member Author

My VS editor is using the JSBSim standard 😉

https://github.com/JSBSim-Team/jsbsim/blob/master/.editorconfig

(base) C:\source\jsbsim>type .\.editorconfig
root = true

[*.{h,hpp,cpp}]
indent_style = space
indent_size = 2

The diff - 2f177d9 in Github online shows thing aligned, except for the explicit change I made to the comment indent. Although double-checking it looks like the original code used tabs.

I was planning on submitting a separate commit to fix up all the other comment indents, in which case I'll get the editor to convert all the tabs as well to match the JSBSim standard.

@bcoconni bcoconni merged commit 65618e8 into JSBSim-Team:master Sep 28, 2024
29 checks passed
@bcoconni
Copy link
Member

I was planning on submitting a separate commit to fix up all the other comment indents, in which case I'll get the editor to convert all the tabs as well to match the JSBSim standard.

All good then 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants