Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a number of minor changes and fixes:
MinGW32
has been renamed toMinGW
as MinGW is no longer limited to 32 bits as stated on their website.target_include_directories
, following the lead of PR fix: target include directories #1022 (there are still a few places that useinclude_directories
and this will be addressed in a later PR).test_inherit_with_extra_args
more robust. Indeed there are some subtleties between__cinit__
and__init__
:root_dir
andpm_root
are properly handled.FGFDMExec
has no constructor__init__
, there is no need to call it.