Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we were only testing that JSBSim was successfully compiling on Apple M1 chips using cross-compilation on Intel MacOS GitHub runners. The resulting binaries were not tested on the actual hardware so we were happily assuming that if it compiles then it runs swiftly. And everyone knows how reliable that criterion is 😄
These dark ages are now over: GitHub just introduced M1 MacOS runners, so this PR implements the testing of JSBSim on that platform.
Note that the floating point precision requirement had to be slightly relaxed at some places in the unit tests ...despite using the flag
-fno-fast-math
. If someone who has access to an M1 Macbook or equivalent knows better then by all means submit fixes 👍Note also that the issue that was fixed by PR #143 (random failure of
TestActuator.py
) is resurfacing with M1 MacOS runners. This has been fixed again by extending further the waiting time oftest_regression_bug_1503
:jsbsim/tests/TestActuator.py
Lines 94 to 130 in 6f0c4d8