Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frankenstein H2 dev #757

Draft
wants to merge 5 commits into
base: dev-h2
Choose a base branch
from
Draft

Frankenstein H2 dev #757

wants to merge 5 commits into from

Conversation

kdorheim
Copy link
Contributor

@kdorheim kdorheim commented Nov 6, 2024

This PR is in progress! It is meant to address issue #749

To consider

  • do we want the R bindings for the emission coefficients? if we include the H2 coeff, should we also include the other emission species?
  • Include update of the equations and example of new behavior

@kdorheim kdorheim changed the title Feature/h2 ch4 lifetime Implement H2 coefficient for OH lifetime Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

@kdorheim kdorheim changed the title Implement H2 coefficient for OH lifetime Frankenstein H2 dev Nov 26, 2024
@kdorheim
Copy link
Contributor Author

Unfortunately this PR has turned into a bit of a monster of H2 dev things and will probably end up being deleted. I have branched off of it to isolate the the dev better and will be submitting those are PRs instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant