-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font mismatch among different controls #64
Comments
Work in progress. |
I think it's normal to have some font size differences between some of the controls, like for instance TitledPane vs Label. TitledPane is like the header of a section. |
@dukke yes. it problem, i try it fix. |
Indeed it might be okay for TitledPane font to be different. But I figured I include it so we check with Fluent Design to see if we got the font size correct. Not sure if Fluent Design has a TitledPane but if it does it would be good to ensure the font follows the standard. |
Indeed Fluent Design doesn't have a Titled Pane. On another note, JMetro is heavily inspired by Fluent Design and we usually follow it, but if we think we can do better, even if it means not following FD rules on occasion, we won't follow those FD rules. |
Makes sense. |
There's various controls that don't exist in FD and exist in JMetro. |
.. another one I remembered are the icons in PasswordField and TextField that appear when you've entered text in them, for showing the password and clearing the text respectfully. |
I've pushed this #65 |
..to be more precise there's a "Alignment test" tab that has various controls layed out and shows how they align with each other. |
Thanks for the update. So if I understood correctly it hasn't been fixed yet, but a Test is added to help with fixing? |
Yes, that's it. A test app to test that all controls line up. The default size will probably get smaller to be better for people that are transitioning from Modena, in that case the size change won't be so different. I'll be working on this on this weekend. |
I think it's okay for the default size not to match Modena as long as it matches Windows Fluent defaults. Does Windows Fluent provide default size spec? |
Fluent Design default specs are too big, I think. Developers have complained about this and that's why they'll be providing a compact mode. When they're building apps with FD everything is too big and not ideal for desktop productivity apps. My thought is that JMetro will follow the inverse approach, start small (like the default Modena size) which is usually what developers building desktop apps want. And if you want to make things bigger you just have to add an initial statement at the root class to define a bigger font size:
Everything will adjust and get bigger (font size of controls and padding). I think there's a reason why FD has bigger controls and font size by default. Microsoft's desktops and hardware have touch capabilities as well as mouse and keyboard input. A Microsoft surface laptop can both be used with mouse and keyboard or detached and used through touch. Touch requires controls to be bigger so that they can easily be manipulated though touch. This is why I think they make everything bigger so that it can be both used though touch or with the mouse and keyboard. |
This has been fixed on release version 5.4. Thanks, |
Awesome, thanks! |
If you so desire, you can quickly change to a bigger size by doing what I said above and in the release notes. Just one simple instruction and all should hopefully work. Usually in big monitors, on Windows, I need to change the scaling of controls for that monitor in Windows settings. Even for other apps and even for Windows itself. Because like you say the size of things is too small for these monitors. Thanks, |
Different controls seem to have different default fonts.
See the font size and color of Label vs Button vs Checkbox vs ChoiceBox vs TitledPane:
The text was updated successfully, but these errors were encountered: