Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rossrad.dat with rossrad.nc #1083

Closed
RussTreadon-NOAA opened this issue Oct 10, 2024 · 1 comment · Fixed by #1084
Closed

Replace rossrad.dat with rossrad.nc #1083

RussTreadon-NOAA opened this issue Oct 10, 2024 · 1 comment · Fixed by #1084
Assignees
@RussTreadon-NOAA
Labels
bug Something is not working SOCA Sea-ice, Ocean, and Coupled Assimilation

Comments

@RussTreadon-NOAA
Copy link
Contributor

Description

Files .gitattributes, test/CMakeLists.txt, and tutorial/tutorial_tools.sh reference rossrad.dat. However, test/Data/ contains rossrad.nc. References to rossrad.dat should be rossrad.nc.

To Reproduce:

  1. clone soca repository
  2. from the top level directory execute grep -r rossrad.dat . to find rossrad.dat references
./test/CMakeLists.txt:  Data/rossrad.dat
./tutorial/tutorial_tools.sh:    ln -sf $datadir/Data/rossrad.dat .
./.gitattributes:test/Data/rossrad.dat filter=lfs diff=lfs merge=lfs -text
  1. from the top level directory execute find . -name "rossrad.nc" -print to find rossrad.nc
./test/Data/rossrad.nc
  1. The suffix on the rossrad file should be .nc, not .dat
@RussTreadon-NOAA RussTreadon-NOAA added bug Something is not working SOCA Sea-ice, Ocean, and Coupled Assimilation labels Oct 10, 2024
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Oct 10, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Work for this issue will be done in bugfix/rossrad

RussTreadon-NOAA added a commit that referenced this issue Oct 10, 2024
@RussTreadon-NOAA
replace rossrad.dat with rossrad.nc (#1083)
9d9d318
@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue Oct 10, 2024
Merged
travissluka added a commit that referenced this issue Oct 11, 2024
@RussTreadon-NOAA @travissluka
replace rossrad.dat with rossrad.nc (#1083) (#1084)
761d271 
* replace rossrad.dat with rossrad.nc (#1083)

* remove rossrad.nc from gitattributes

---------

Co-authored-by: Travis Sluka <travissluka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
bug Something is not working SOCA Sea-ice, Ocean, and Coupled Assimilation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace rossrad.dat with rossrad.nc (#1083) JCSDA-internal/soca
1 participant
@RussTreadon-NOAA