-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matching by batch of schemas with filename_pattern
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the ValidateCsv command to handle multiple CSV files and schema files, and enhanced the validation process. This change enables the application to match multiple CSV files to their corresponding schemas based on filename patterns; providing more specific validations and detailed feedback for the user. Furthermore, committed changes included adjustments for readability, additional error checks and enhanced output formatting for validation results.
This commit implements quick mode in both CSV and schema validation. It enables the process to stop at the first detected error when quick mode is activated. The logic for schema and CSV validation has been updated to support early exit on detecting errors. Minor text changes were also made to improve clarity and output messages.
This commit introduces a quick mode in CSV and schema validation process, enhancing the performance by terminating the process upon encountering the first error. Also, there have been some updates in logic handling validation as well as code refactoring which involves clear and descriptive output messages.
The quick mode feature has been added to the CSV and schema validation test, allowing for faster performance by halting upon the first error. This update also includes improvements in validation logic and better output messages, achieved through code refactoring.
SmetDenis
changed the title
Matching by batch of schemas by
Matching by batch of schemas with Mar 22, 2024
filename_pattern
filename_pattern
Pull Request Test Coverage Report for Build 8389643575Details
💛 - Coveralls |
More efficient CSV validation process has been implemented in the GitHub workflows. Now, it includes a quick mode, which dramatically improves the performance by stopping at the first error. It also provides more user-friendly and informative output messages.
A new test has been added for scenarios where the CSV schema does not include a filename pattern. This ensures that the validation process correctly identifies schemas without filename patterns and applies them to all CSV files found in the specified directory. Additionally, a new demo_invalid_no_pattern.yml has been added to aid in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the ValidateCsv command to handle multiple CSV files and schema files, and enhanced the validation process. This change enables the application to match multiple CSV files to their corresponding schemas based on filename patterns; providing more specific validations and detailed feedback for the user. Furthermore, committed changes included adjustments for readability, additional error checks and enhanced output formatting for validation results.