Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching by batch of schemas with filename_pattern #70

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Conversation

SmetDenis
Copy link
Member

Updated the ValidateCsv command to handle multiple CSV files and schema files, and enhanced the validation process. This change enables the application to match multiple CSV files to their corresponding schemas based on filename patterns; providing more specific validations and detailed feedback for the user. Furthermore, committed changes included adjustments for readability, additional error checks and enhanced output formatting for validation results.

Denis Smet added 5 commits March 22, 2024 13:43
Updated the ValidateCsv command to handle multiple CSV files and schema files, and enhanced the validation process. This change enables the application to match multiple CSV files to their corresponding schemas based on filename patterns; providing more specific validations and detailed feedback for the user. Furthermore, committed changes included adjustments for readability, additional error checks and enhanced output formatting for validation results.
This commit implements quick mode in both CSV and schema validation. It enables the process to stop at the first detected error when quick mode is activated. The logic for schema and CSV validation has been updated to support early exit on detecting errors. Minor text changes were also made to improve clarity and output messages.
This commit introduces a quick mode in CSV and schema validation process, enhancing the performance by terminating the process upon encountering the first error. Also, there have been some updates in logic handling validation as well as code refactoring which involves clear and descriptive output messages.
The quick mode feature has been added to the CSV and schema validation test, allowing for faster performance by halting upon the first error. This update also includes improvements in validation logic and better output messages, achieved through code refactoring.
@SmetDenis SmetDenis changed the title Matching by batch of schemas by filename_pattern Matching by batch of schemas with filename_pattern Mar 22, 2024
@coveralls
Copy link

coveralls commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8389643575

Details

  • 185 of 199 (92.96%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 95.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Utils.php 32 33 96.97%
src/Validators/CsvValidator.php 19 21 90.48%
src/Validators/SchemaValidator.php 15 18 83.33%
src/Commands/ValidateCsv.php 118 126 93.65%
Totals Coverage Status
Change from base Build 8380807034: -0.5%
Covered Lines: 1103
Relevant Lines: 1152

💛 - Coveralls

Denis Smet added 3 commits March 22, 2024 14:35
More efficient CSV validation process has been implemented in the GitHub workflows. Now, it includes a quick mode, which dramatically improves the performance by stopping at the first error. It also provides more user-friendly and informative output messages.
A new test has been added for scenarios where the CSV schema does not include a filename pattern. This ensures that the validation process correctly identifies schemas without filename patterns and applies them to all CSV files found in the specified directory. Additionally, a new demo_invalid_no_pattern.yml has been added to aid in testing.
@SmetDenis SmetDenis merged commit ac2f1c0 into master Mar 22, 2024
23 of 24 checks passed
@SmetDenis SmetDenis deleted the muti-schema branch March 22, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants