Refactor regex validation checks to a dedicated method #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 19, 2024 23:31
This commit modifies the SchemaValidator code, ensuring that values used for examples are cast as strings before validation. This change addresses potential issues with non-string values, improving the robustness and accuracy of the schema validation process. Updates have also been made to the associated tests and documentation.
The code has been updated to move regex validation checks to a Utility method, improving reusability. Multiple classes including IsDomain, IsFloat, IsGeohash, IsInt, IsUsaMarketName, RegEx, CsvValidator, all now utilize this utility method. This enhancement provides a centralized place for handling regex validations ensuring uniform error handling across the application. Minor modifications were also made to related comments and tests.
Pull Request Test Coverage Report for Build 8351209496Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been updated to move regex validation checks to a Utility method, improving reusability. Multiple classes including IsDomain, IsFloat, IsGeohash, IsInt, IsUsaMarketName, RegEx, CsvValidator, all now utilize this utility method. This enhancement provides a centralized place for handling regex validations ensuring uniform error handling across the application. Minor modifications were also made to related comments and tests.