Invalidate old cache versions #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachtjasmin
suggested changes
Jul 18, 2023
src/libs/caching.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| import { debug, error } from "./logging"; | |||
| import { storage } from "webextension-polyfill"; | |||
| import Browser, { storage } from "webextension-polyfill"; | |||
There was a problem hiding this comment.
Suggested change
| import Browser, { storage } from "webextension-polyfill"; | |
| import { runtime, storage } from "webextension-polyfill"; |
I'm not sure whether importing the whole Browser object messes with the tree shaking. I think it'd be better to just import the runtime part of it and adjust the code in the rest of the file accordingly.
src/libs/fetchPronouns.js
Outdated
| @@ -21,26 +23,24 @@ export async function fetchPronouns(dataID, accountName, type) { | |||
| debug(cacheResult); | |||
| // Extract the current cache by using object destructuring. | |||
| if (accountName in cacheResult.pronounsCache) { | |||
| const { value, timestamp } = cacheResult.pronounsCache[accountName]; | |||
| const { value, timestamp, version } = cacheResult.pronounsCache[accountName]; | |||
There was a problem hiding this comment.
At this point we really shouldn't implement cache logic in this file anymore, otherwise it becomes way to messy once we want to support other pages.
Would be kind if you could extract it into the caching lib.
nachtjasmin
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever we publish a new version old cache entries stay around, potentially breaking things.
To mitigate this issue, check with which version a cache entry was created and refresh if it's not the same.