Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pronouns.page support #7

Closed
ItsVipra opened this issue May 24, 2023 · 1 comment · Fixed by #40
Closed

Add pronouns.page support #7

ItsVipra opened this issue May 24, 2023 · 1 comment · Fixed by #40
Labels
enhancement New feature or request major a major change is nessecary to close this issue

Comments

@ItsVipra
Copy link
Owner

Reasoning

Some people only link to pronouns.page for their pronouns.
These instances are currently treated as "no pronouns found" in ProToots.
However pronouns.page does have a public API so adding support for those links wouldn't be too big of an issue.

Implementation idea

When finding a pronouns.page link in a user's field/bio send a GET request to pronouns.page and proceed with the response, as pronouns were found in the field/bio.

@ItsVipra ItsVipra added the enhancement New feature or request label May 24, 2023
@ItsVipra
Copy link
Owner Author

Languages

pronouns.page/api/profile/get/{username}?version=2 provides pronouns in every language defined by the user. Displaying all of them is not viable, as that could take up too much space.
Instead I propose we display only two:

  • (if available) pronouns matching the browsers language
  • english pronouns

In the rare case that English is not available, maybe display just the first language on the profile?

Opinion

pronouns.page also supplies an opinion field with each pronoun. We pay attention to only use pronouns that are actually okay with the pronouns.page owner (okay, yes).

Linking to the page

We can add the pronouns.page icon to the plate so that users can click on it to get to the respective page. We can display this anytime we find a pronouns.page link.
However: If an author also supplies their pronouns outside of pronouns.page we should prefer using those for simplicity.

@ItsVipra ItsVipra added the major a major change is nessecary to close this issue label May 25, 2023
nachtjasmin added a commit that referenced this issue Jul 10, 2023
nachtjasmin added a commit that referenced this issue Jul 10, 2023
@nachtjasmin nachtjasmin linked a pull request Jul 10, 2023 that will close this issue
nachtjasmin added a commit that referenced this issue Jul 10, 2023
nachtjasmin added a commit that referenced this issue Jul 10, 2023
nachtjasmin added a commit that referenced this issue Jul 10, 2023
nachtjasmin added a commit that referenced this issue Jul 10, 2023
nachtjasmin added a commit that referenced this issue Jul 10, 2023
nachtjasmin added a commit that referenced this issue Jul 11, 2023
@se4598 se4598 mentioned this issue Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major a major change is nessecary to close this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant