Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Mark Many... excludes last byte. #38

Closed
OxyMauron opened this issue Feb 27, 2021 · 3 comments
Closed

Bug: Mark Many... excludes last byte. #38

OxyMauron opened this issue Feb 27, 2021 · 3 comments

Comments

@OxyMauron
Copy link

Marking C43842-C43843 will only mark C43842 with the indicated label.

@binary1230
Copy link
Collaborator

binary1230 commented Mar 14, 2021

documenting my own actions.....

I did this:
image

And got this:
image

That all works correctly, but,

Yes, it does seem a little counterintuitive from a UX standpoint that the last number you enter isn't included in the range, even if the action performed is correct.

Seems like a decent improvement would be to make the labels be "Start at Address" and "Up to AND INCLUDING address". That would look like this:

If you enter the same address (0xC43842) in both boxes, the #bytes will say 0x01 byte count
If you enter the start = 0xC43842, up to and including 0xC43843, the #bytes will say 0x02 byte count
If you enter the start = 0xC43842, up to and including 0xC43851, the #bytes will say 0x10 byte count
If you enter the start = 0xC43842, up to and including 0xC43852, the #bytes will say 0x11 byte count


I needed to mock this up just to get my head around it, so here's what it looks like if you entered:

enter: start @ 0xC00010
enter: "16 (decimal) bytes"
it calculates: up to and including 0xC0001F

And it would look like this:
image

I think that makes a bit more sense intuitively, since users are more likely to enter the starting address and # of bytes, and have the form calculate the rest. When it does, the second ending number will reflect something actually being marked and not "one beyond" that.

I'm going to sleep on this but good with implementing this change if no one else objects

@binary1230
Copy link
Collaborator

Changing it to be like this

Before:
image

after:
image

binary1230 added a commit that referenced this issue May 23, 2021
- from #38
- backport interfaces and code from v3.0 branch
@binary1230
Copy link
Collaborator

fixed in master branch, next build will have this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants