Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1313 Attach appropriate function to ipc "select-souce" to fix screen sharing #1315

Merged

Conversation

camspiers
Copy link
Contributor

In order to test I ran:

npm run dist:linux:appimage 

Then:

./dist/teams-for-linux-1.7.3.AppImage --no-sandbox

And I was able to successfully screen share during a call.

Copy link

@hugoalonsocapuz hugoalonsocapuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IsmaelMartinez
Copy link
Owner

Thanks a lot! To avoid confusion with the same 1.7.3 been out one with the fix and one without, can you increase the version number in

"version": "1.7.3",
to 1.7.4 and add a release description in https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/com.github.IsmaelMartinez.teams_for_linux.appdata.xml#L17 ? Really appreciated.

@camspiers camspiers force-pushed the fixes/screen-sharing branch from 780b996 to 4d0dbd0 Compare June 25, 2024 08:58
@camspiers
Copy link
Contributor Author

@IsmaelMartinez Updated.

@camspiers
Copy link
Contributor Author

Opps, I noticed I need to do package.json too.

@camspiers camspiers force-pushed the fixes/screen-sharing branch from 4d0dbd0 to 982277e Compare June 25, 2024 09:00
@camspiers
Copy link
Contributor Author

Ready now.

@IsmaelMartinez IsmaelMartinez merged commit 9d2c1dd into IsmaelMartinez:develop Jun 25, 2024
3 checks passed
@IsmaelMartinez
Copy link
Owner

Thanks again! building now so it should be released pretty soon.

@okobloko
Copy link

okobloko commented Nov 26, 2024

Hi there. Screen sharing in Teams (1415/24102001318) on Kbuntu is not working. Did the changes mentioned here get built and released? Is this a new problem? When "debugging" in Teams I see an unhandled error when trying to click on the screen/window selection :

Unhandled error/rejection {"isTrusted":true}

I have since figured out this only happens with Wayland!

@IsmaelMartinez
Copy link
Owner

@okobloko , see #1463 or #1331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants