-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1313 Attach appropriate function to ipc "select-souce" to fix screen sharing #1315
Fix #1313 Attach appropriate function to ipc "select-souce" to fix screen sharing #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks a lot! To avoid confusion with the same 1.7.3 been out one with the fix and one without, can you increase the version number in Line 3 in d9dee34
|
780b996
to
4d0dbd0
Compare
@IsmaelMartinez Updated. |
Opps, I noticed I need to do package.json too. |
…uce" to fix screen sharing
4d0dbd0
to
982277e
Compare
Ready now. |
Thanks again! building now so it should be released pretty soon. |
Hi there. Screen sharing in Teams (1415/24102001318) on Kbuntu is not working. Did the changes mentioned here get built and released? Is this a new problem? When "debugging" in Teams I see an unhandled error when trying to click on the screen/window selection : Unhandled error/rejection {"isTrusted":true} I have since figured out this only happens with Wayland! |
In order to test I ran:
Then:
And I was able to successfully screen share during a call.