Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1806 - exploding colons. #57

Merged
merged 4 commits into from
May 3, 2021

Conversation

ajstanley
Copy link
Contributor

GitHub Issue: (Islandora/documentation#1806)

What does this Pull Request do?

Not so much a one-line as a one-character change to make predicates explode on the first colon only.

What's new?

As well as addressing this issue I broke the rules a bit here by throwing a sort function in to make the Settings form more readable. (It relates back to yesterday's issue with adding in-line documentation; It seemed like overkill to have an entire PR just to see that the configs were sorted alphabetically)

How should this be tested?

Add properties: with a colon in it to an rdf config file.

  field_myfield:
    properties:
      - 'wikidata:Property:P7535'

Save an object with this field defined with an entered value and see if it shows up when viewing the json ld. The previous example will only work if you have registered wikidata as a prefix - it's meant to serve as an example only.

Interested parties

Tag @seth-shaw-unlv @dannylamb

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I like the ksort addition; it makes the form easier to use.

@seth-shaw-unlv seth-shaw-unlv merged commit dfd99c4 into Islandora:8.x-1.x May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants