Ensure node exists before using it. #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seth-shaw-unlv
approved these changes
Mar 24, 2022
|
Oh yeah, tests should be okay once we get #862 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2067
Release pull requests, etc.)
https://islandora.slack.com/archives/CM5PPAV28/p1648151773957529
What does this Pull Request do?
Fixes a bug that can be encountered when navigating to a
node/anode/mediawhenanodedoes not exist.What's new?
Checking if things exist.
How should this be tested?
Navigating to
yoursite/node/somethingthatdoesnotexist/mediaand you should a WSOD. Full stack trace noted in the issue.Interested parties
@Islandora/8-x-committers, @hachacha for catching it.