added additional exception

[ajstanley]

GitHub Issue: Issue 1992

What does this Pull Request do?

Adds an additional exception so we won't see a whitescreen when configuring iiif

What's new?

One new catch statement

How should this be tested?

Navigate to admin/config/islandora/iiif and enter a bogus (but well-formed) URL. You should see your URL rejected, but no WSOD.

Documentation Status

No changes required

Interested parties

Tag @Islandora/8-x-committers

[seth-shaw-unlv]

Point of clarification, a well formed URL worked without the PR.

I needed to give it a bad URL, http://bah/iiif/2 for it to WSOD.

[seth-shaw-unlv]

Confirmed that the PR fixes the WSOD when a bad URL is submitted.

[seth-shaw-unlv]

Unfortunately, github actions are not happy about something.

[ajstanley]

Yeah - I'm seeing this

Problem 1
    - drupal/migrate_tools dev-5.x requires drupal/core ^9.1 -> found drupal/core[9.1.0-alpha1, ..., 9.4.x-dev] but the package is fixed to 8.9.11 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

So, nothing I touched? No idea what's going on.

[DonRichards]

Isn't cantaloupe expecting a HTTPS connection? Wondering if it's an http connection that would make the content a mismatch that most current browsers won't allow.

[DonRichards]

The default in isle-dc is https://${DOMAIN}/cantaloupe/iiif/2

[seth-shaw-unlv]

@DonRichards, yeah a mismatch between TLS between Drupal and Cantaloupe does cause openseadragon to fail on Chrome and others, but that is unrelated to this particular PR which is solely focused on the form working correctly.

@ajstanley , migrate_tools 5.x-dev now requires Drupal 9.1. We need to adjust our composer.json to use migrate_tools:5.0 until we drop support for Drupal 8. Should we do that as a separate PR or roll that into this one?

[seth-shaw-unlv]

The CI blockers are based on unrelated issues. I'm going to trust @ajstanley when he says coder isn't complaining and this won't break any tests, so I'm going to use Admin powers to merge.