Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Hacking on Islandora 8" for #1794 #1795

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Remove "Hacking on Islandora 8" for #1794 #1795

merged 2 commits into from
Apr 7, 2021

Conversation

manez
Copy link
Member

@manez manez commented Apr 7, 2021

Purpose / why

Remove obsolete documentation page Hacking on Islandora 8 to address #1794

What changes were made?

Removed a page and edited mkdocs.yml to take it out of the menu. Since it was in a a nested list with only one other item, I removed the parent and bumped up the other entry.

Verification

This involves the menu, so probably worth a test docs build.

Interested Parties

@dannylamb or @Islandora/documentation


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@dannylamb dannylamb merged commit 1ec1111 into Islandora:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants