Drupal 9

[seth-shaw-unlv]

GitHub Issue: Resolves Islandora/documentation#1679

What does this Pull Request do?

Drupal 9 readiness.

What's new?

• Changes deprecated methods for the new ones (courtesy of rector).
• Updates minor versions of required modules in composer to the Drupal-9 versions.
• Added core_version_requirement: ^8 || ^9.

How should this be tested?

• Apply the PR
• composer require drupal/geolocation:^3.2 drupal/token:^1.7
• Run upgrade_status to ensure no known issues found: composer require 'drupal/upgrade_status:^3.0' && drush en -y devel upgrade_status && drush us-a controlled_access_terms

Interested parties

@Islandora/8-x-committers, esp @kayakr

[seth-shaw-unlv]

Any takers, @Islandora/8-x-committers?

[elizoller]

i can give it a whirl if you'd like - anything in particular i should look for?

[seth-shaw-unlv]

Nope. It should be ready to go. I just need a Drupal 9 compatible release so I can get my ArchivesSpace module updated too.

[seth-shaw-unlv]

Although a smoke test never hurts!

[elizoller]

Upgrade status is returning 2 warnings:

Controlled Access Terms, --
Scanned on Mon, 11/16/2020 - 15:42

FILE:
web/modules/contrib/controlled_access_terms/tests/src/Kernel/EdtfUtilsTest.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually      Class PHPUnit\Framework\TestCase not found.
--------------------------------------------------------------------------------
Check manually 15   Class PHPUnit\Framework\TestCase not found.
--------------------------------------------------------------------------------

[seth-shaw-unlv]

Huh... I wonder how it missed that before. 😕

Thanks.... I'll see what I can do.

[seth-shaw-unlv]

@elizoller, do you have devel installed on the test box? See https://www.drupal.org/project/upgrade_status/issues/3137754.

[kayakr]

@seth-shaw-unlv The changes visible at Files changed make sense with respect to compatibility to Drupal 9 but I look at the composer patch I'd need to apply https://patch-diff.githubusercontent.com/raw/Islandora/controlled_access_terms/pull/58.patch it includes a bunch of other changes around controlled_access_terms_defaults config yml's and field changes. Am I driving composer wrong?

[elizoller]

i did drush pm-uninstall devel and re-ran drush us-a controlled_access_terms and got the same output - is that what you meant by having 'devel' installed?

[seth-shaw-unlv]

@kayakr, I believe your patch was based on an older commit. The master→main commit that contains a bunch of these changes was back in September.

[seth-shaw-unlv]

@elizoller, huh... no devel should be installed: drush en -y devel.

[elizoller]

devel was enabled before. did drush pm-enable devel and drush us-a controlled_access_terms and got the same error. i'll try another build.

[kayakr]

@kayakr, I believe your patch was based on an older commit. The master→main commit that contains a bunch of these changes was back in September.

https://patch-diff.githubusercontent.com/raw/Islandora/controlled_access_terms/pull/58.patch is a patch based on your current PR. What I'm seeing is the changes included in 8.x-1.x...seth-shaw-unlv:8.x-1.x - did you rebase your fork before making the Drupal 9 changes?

[seth-shaw-unlv]

@kayakr, oh! I see that now. I thought I had rebased my branch before I made the changes... and the github interface is only showing what I changed... but maybe I didn't rebase and Github is glossing over that.

[dflitner]

Controlled Access Terms, --
Scanned on Mon, 11/16/2020 - 16:03

No known issues found.

This is with the Islandora box from dev.

[seth-shaw-unlv]

Ah, I simply did a merge upstream (see 720e64e), instead of a rebase.

[seth-shaw-unlv]

Controlled Access Terms, --
Scanned on Mon, 11/16/2020 - 16:03

No known issues found.

This is with the Islandora box from dev.

🎉 At least it isn't just me. 😅

[elizoller]

then ignore me - debbie, review and merge?

[seth-shaw-unlv]

Ah, for future reference, @elizoller,

Adding drupal/core-dev

In order to be able to run Drupal core's PHPUnit test suite, you will have to install an additional metapackage, drupal/core-dev.

(See https://www.drupal.org/docs/develop/using-composer/starting-a-site-using-drupal-composer-project-templates#s-adding-drupalcore-dev.)

[seth-shaw-unlv]

Thanks, @dflitner!

[elizoller]

thank you @seth-shaw-unlv that did the trick
and thanks @dflitner for swooping in with the merge