Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #108

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Update .travis.yml #108

merged 3 commits into from
Nov 4, 2020

Conversation

dannylamb
Copy link
Contributor

What does this Pull Request do?

Travis changes to use scripts at https://github.com/Islandora/islandora_ci

How should this be tested?

Travis should work

Interested parties

@rosiel

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #108 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #108   +/-   ##
=========================================
  Coverage     91.89%   91.89%           
  Complexity      175      175           
=========================================
  Files             9        9           
  Lines           728      728           
=========================================
  Hits            669      669           
  Misses           59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a8206...1ee5460. Read the comment docs.

@whikloj
Copy link
Member

whikloj commented Nov 1, 2020

Travis is auto-updating to Composer 2.x.

doctrine/migrations is updating its dependencies which causes one error. That one seems easily fixable, however symfony/flex requires a plugin that is only for Composer 1.x which is causing a second error. That seems like it would require moving off of symfony/flex.

Or you can try forcing composer not to auto-update.

@dannylamb
Copy link
Contributor Author

I just merged #107 and I'm going to update and try again.

@dannylamb
Copy link
Contributor Author

Yep, that worked. Many thanks @whikloj and @alxp

@dannylamb
Copy link
Contributor Author

This is good to go @rosiel, or any @Islandora/8-x-committers for that matter

@seth-shaw-unlv
Copy link
Contributor

I will note Travis is reporting the following message from tests:

1) Islandora\Milliner\Tests\MillinerControllerTest::testMethodsReturnMillinerErrors
Trying to @cover or @use not existing method "\Islandora\Milliner\Controller\MillinerController::createVersion".

But that is a separate issue. Let's merge this so Travis is working properly.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit 937e394 into dev Nov 4, 2020
@seth-shaw-unlv seth-shaw-unlv deleted the update-scripts-location branch November 4, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants