Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module directories installed by custom.sh don't have correct permissions #76

Closed
mjordan opened this issue Jun 18, 2015 · 3 comments
Closed

Comments

@mjordan
Copy link
Contributor

mjordan commented Jun 18, 2015

custom.sh runs "privileged" (the default), and since it runs as the last provisioner script, any modules or libraries installed in it do not receive the permissions change added in 63a78f9 (and since custom.sh is privileged, the directoreis are owned by root). Two possible fixes: 1) document that any custom.sh that installs modules or libraries needs to run the following after it installs them:

sudo chown -hR vagrant:www-data "$DRUPAL_HOME"/sites/all/modules
sudo chmod -R 755 "$DRUPAL_HOME"/sites/all/libraries
sudo chmod -R 755 "$DRUPAL_HOME"/sites/all/modules

or 2) those permissions commands get moved into an inline shell provisioner (or additional external script) that gets run after custom.sh, or maybe within the if File.exist? block that runs custom.sh if it exists. There may be other more preferable fixes.

@ruebot
Copy link
Contributor

ruebot commented Aug 24, 2015

I'd go with option 1. We could document it in the README, and that should resolved it.

@ruebot
Copy link
Contributor

ruebot commented Sep 28, 2015

@mjordan would it be worth moving the call out to custom.sh up to right before post.sh? I think that would resolve this issue, and would be better than documenting. If so, I can take care of this.

@mjordan
Copy link
Contributor Author

mjordan commented Sep 28, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants