Add code server healthcheck #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b77f11e to
a5ee02f
Compare
a5ee02f to
676339d
Compare
|
I am going to go ahead and merge this since the Glad we have end to end nightly tests to catch these sorts of errors :). Was alerted in slack when the nightly isle-site-template build failed https://github.com/Islandora-Devops/isle-site-template/actions/runs/13198877336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the image base is drupal, the code server container had a healthcheck from nginx (and was failing). Instead, we should hit the
/healthzendpoint in the codeserver.