Fix orphaned media view filter. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #34 .
Previously, the "orphaned" filter found items where media_of was not set.
However, the most likely "orphan" case is when a node is deleted, and then media_of remains set but does not link to a real node.
This new filter for "Orphans" finds both:
I've had a bit of trouble trying to get the nid of the deleted node to display transparently to the user. This is really difficult! Drupal does a lot of work to hide from you the fact that there is a referenced entity which does not exist.
Nonetheless, this change addresses "Finding orphans" which are being missed by the current view.