Add library for pdf.js #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rosiel - this should address the issues with PDF.js that you found in the sandbox during your demo |
nigelgbanks
approved these changes
Feb 24, 2022
composer.lock
Outdated
| "support": { | ||
| "issues": "https://github.com/Islandora/documentation/issues", | ||
| "source": "https://github.com/Islandora/controlled_access_terms/tree/2.1.1" | ||
| }, | ||
| "time": "2022-01-26T13:15:07+00:00" | ||
| }, | ||
| { | ||
| "name": "islandora/crayfish-commons", |
There was a problem hiding this comment.
Odd for this to be in an install for the Drupal site.
|
Thanks Nigel! cc @Natkeeran @rosiel the next build of the sandbox SHOULD include this fix. |
alxp
pushed a commit
to roblib/islandora-sandbox
that referenced
this pull request
Aug 12, 2022
Update Composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #8 and should fix the missing PDF.js library on the sandbox. That library must be included separately with Composer, as it turns out.