The TypeScript typings have errors and make this library unusable from TypeScript

[slikts]

The TypeScript typings have errors that prevent code depending on this library from compiling in TypeScript; namely, the CheerioSelector and CheerioStatic types are missing definitions.

I'm not sure what the proper fix is; I made a fork that adds /// <reference path="../../../@types/cheerio/index.d.ts" /> to lib/index.d.ts so that the library would compile, but it seems like a 'hacky' workaround.

[IonicaBizau]

/cc'ing @andrewneo

[edorivai]

For what it's worth, installing @types/cheerio let's me compile. Not sure how to define dependencies for @types.

[slikts]

Seems like it should be a peer dependency.

[edorivai]

But isn't that kinda weird, because then non-TS users will get "missing peer dependency" warnings

[slikts]

Non-TS users can still benefit from TS typings; for example, VS Code TS type intelligence also works in JS files.

[edorivai]

Hmm, good point 🤔 . Wouldn't that make a normal dependency a better fit then?

[IonicaBizau]

I merged #101. I'm wondering if this is still an issue. Can you check?

[edorivai]

@IonicaBizau If I remember correctly, #101 was not meant to fix this issue. It arose from another change that just contained faulty TS.

[kpratik2015]

The TypeScript typings have errors that prevent code depending on this library from compiling in TypeScript; namely, the CheerioSelector and CheerioStatic types are missing definitions.

I'm not sure what the proper fix is; I made a fork that adds /// <reference path="../../../@types/cheerio/index.d.ts" /> to lib/index.d.ts so that the library would compile, but it seems like a 'hacky' workaround.

I had to put /// <reference path="../../../node_modules/@types/cheerio/index" />

[IonicaBizau]

Is this still a thing? I am not expert in TS, but I merged some related PRs.

[IonicaBizau]

Duplicate of #121

Moving the discussion there.