Typescript Fixes were not merged

[actraiser]

I believe that the fixes provided in #116 were not correctly merged and hence not included in the 5.1.1 release of scrape-it.

The index.d.ts in current scrape-it 5.1.1

declare namespace scrapeIt {
    export interface ScrapeOptions {
        [key: string]: string | ScrapeOptionListWithData | ScrapeOptionListWithConvert | ScrapeOptionElement;
    }

    export interface ScrapeOptionElement {
        selector?: string;
        convert?: (value: any) => any;
        how?: string | ((element: CheerioSelector) => any);
        attr?: string;
        trim?: boolean;
        closest?: string;
        eq?: number;
        texteq?: number;
    }

    export interface ScrapeOptionList {
        listItem: string;
        data?: ScrapeOptions;
        convert?: (value: any) => any;
    }

    export interface ScrapeResult<T> {
        data: T,
        $: Cheerio,
        response: any,
        body: string
    }

    export function scrapeHTML<T>(body: CheerioStatic | string, options: ScrapeOptions): T;
}

declare function scrapeIt<T>(url: string | object, opts: scrapeIt.ScrapeOptions): Promise<scrapeIt.ScrapeResult<T>>;

declare function scrapeIt<T>(url: string | object, opts: scrapeIt.ScrapeOptions, cb: (err: any, res: scrapeIt.ScrapeResult<T>) => void): void;
export = scrapeIt;

The fixed version of index.d.ts (as provided in the pull request) should be

declare namespace scrapeIt {
  export interface ScrapeOptions {
      [key: string]: string | ScrapeOptionList | ScrapeOptionElement;
  }

  export interface ScrapeOptionElement {
      selector?: string;
      convert?: (value: any) => any;
      how?: string | ((element: CheerioSelector) => any);
      attr?: string;
      trim?: boolean;
      closest?: string;
      eq?: number;
      texteq?: number;
  }

  export interface ScrapeOptionList {
      listItem: string;
      data?: ScrapeOptions;
      convert?: (value: any) => any;
  }

  export interface ScrapeResult<T> {
      data: T,
      $: Cheerio,
      response: any,
      body: string
  }

  export function scrapeHTML<T>(body: CheerioStatic | string, options: ScrapeOptions): T;
}

declare function scrapeIt<T>(url: string | object, opts: scrapeIt.ScrapeOptions): Promise<scrapeIt.ScrapeResult<T>>;

declare function scrapeIt<T>(url: string | object, opts: scrapeIt.ScrapeOptions, cb: (err: any, res: scrapeIt.ScrapeResult<T>) => void): void;
export = scrapeIt;

So with the current 5.1.1 release Typescript is (still) complaining:

node_modules/scrape-it/lib/index.d.ts:3:33 - error TS2304: Cannot find name 'ScrapeOptionListWithData'.

3         [key: string]: string | ScrapeOptionListWithData | ScrapeOptionListWithConvert | ScrapeOptionElement;
                                  ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/scrape-it/lib/index.d.ts:3:60 - error TS2304: Cannot find name 'ScrapeOptionListWithConvert'.

3         [key: string]: string | ScrapeOptionListWithData | ScrapeOptionListWithConvert | ScrapeOptionElement;

@IonicaBizau, could you kindly recheck the pull request and release an updated library version?

Greets
-act

[aa900031]

same problem

[IonicaBizau]

Can you check now?

[actraiser]

Perfect, works! Thank you @IonicaBizau!

-act