Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-05 Fix [PAG] #94

Merged
merged 2 commits into from
May 16, 2024
Merged

M-05 Fix [PAG] #94

merged 2 commits into from
May 16, 2024

Conversation

junkim012
Copy link
Collaborator

@junkim012 junkim012 commented May 12, 2024

  • The rounding direction issue in M-05 is invalid. But more tests are added.
  • Implement try/catch to skip supply/withdraw from a reverting IonPool. The IonPool supply or withdraw can revert in cases of a pause or trying to mint or burn zero amounts.

@junkim012 junkim012 changed the base branch from master to jun/lending-vault May 12, 2024 05:21
Copy link

openzeppelin-code bot commented May 12, 2024

M-05 Fix [PAG]

Generated at commit: 0a29e38d929be188895da6a3305197ce4591938c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
12
38
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@junkim012 junkim012 requested a review from HrikB May 12, 2024 07:19
@junkim012 junkim012 changed the base branch from jun/lending-vault to jun/PAG-C-01 May 13, 2024 08:49
@junkim012 junkim012 merged commit 7802ed9 into jun/PAG-C-01 May 16, 2024
4 of 6 checks passed
@junkim012 junkim012 deleted the jun/PAG-M-05 branch May 16, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant