Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding transferability of the token #69

Closed
wants to merge 8 commits into from
Closed

Conversation

HrikB
Copy link
Contributor

@HrikB HrikB commented Apr 2, 2024

  • Transferability
  • Convert to non-rebasing token
  • Remove increaseAllowance and decreaseAllowance

Copy link

openzeppelin-code bot commented Apr 2, 2024

Adding transferability of the token

Generated at commit: 6e119ac978e59e0c8d15932ff0be4c085c9b1d36

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
11
37
52
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor Author

@HrikB HrikB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just going to add a note here that we should add back interface validation to the deploy scripts before merging. These were removed because function overloading wasn't happening for some reason and it was preventing compilation.

We will likely need to add it back without overloading.

@junkim012 junkim012 mentioned this pull request Apr 29, 2024
@HrikB HrikB closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants